ASoC: SOF: Intel: hda: reduce verbosity of boot error logs #2382
Conversation
plbossart
requested review from
bardliao,
keyonjie,
libinyang and
lyakh
as code owners
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
@plbossart @ranj063 It feels we are sinking deeper with more and more code to handle the ICL boot case. I did spend some time looking at better options, but came back empty handed, so with the off-by-one fixed, seems good to go.
@plbossart did you forget to push? I dont see the updated code |
plbossart
force-pushed
the
fix/boot-error-logs
branch
from
d6e3f15 to
1048f3a
Compare
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
the proposed change is optional
plbossart
force-pushed
the
fix/boot-error-logs
branch
from
1048f3a to
cbc4ccc
Compare
ranj063
left a comment
ranj063
left a comment
There was a problem hiding this comment.
LGTM @plbossart. I like the new macro. I think it will be useful in the future as well
Previous commits reduced the verbosity of errors during boot iterations, but there are still a couple remaining which generate false positives. Errors should only be logged when after last attempt to download firmware failed. Duplicating logs and assigning them different levels based on the iteration number isn't really elegant, use macro as suggested by Guennadi. Suggested-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/boot-error-logs
branch
from
cbc4ccc to
f3a490d
Compare
|
@plbossart are the checkpatch warnings about spaces before tabs legitimate? |
|
sorry @ranj063 looks like I dismissed your review by pushing a tab/space fix. |
|
i'll merge this tonight so that we can have a clean set of CI results - well until we find new issues. |
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
that superfluous empty line is, well, not a deal-breaker I guess
| dev_err(sdev->dev, "error: extended rom status:%s", msg); | ||
| sof_dev_dbg_or_err(sdev->dev, hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS, | ||
| "extended rom status: %s", msg); | ||
|
|
There was a problem hiding this comment.
one empty line too many :-)
With thesofproject/linux#2382 no error logs will generate in boot time. Udpate the err list and ignore list with this update. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
|
Sorry for late but with this change we even not throwing any warning message when boot failed on those first iterations? |
5 participants
Previous commits reduced the verbosity of errors during boot
iterations, but there are still a couple remaining.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com