Skip to content

Add old ignore pattern for sof-kernel-log-check #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiulipan merged 1 commit into from
Sep 24, 2020
Merged

Add old ignore pattern for sof-kernel-log-check #395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tools/sof-kernel-log-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,18 @@ ignore_str="$ignore_str"'|wlo1: authentication with f4:f5:e8:6b:45:bb timed out'
case "$platform" in
icl|cml)
ignore_str="$ignore_str"'|sof-audio-pci 0000:00:1f\.3: status = 0x[0]{8} panic = 0x[0]{8}'
# There will be debug logs at each failed initializaiton of DSP before Linux 5.9
# sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
# sof-audio-pci 0000:00:1f.3: error: status = 0x00000000 panic = 0x00000000
# sof-audio-pci 0000:00:1f.3: error: Error code=0xffffffff: FW status=0xffffffff
# sof-audio-pci 0000:00:1f.3: error: iteration 0 of Core En/ROM load failed: -110
# We will reinit DSP if it is failed to init, and retry 3 times, so the errors in
# debug logs at the frist and second retry can be ignored.
# Check https://github.com/thesofproject/linux/pull/1676 for more information.
# Fixed by https://github.com/thesofproject/linux/pull/2382
ignore_str="$ignore_str"'|error: iteration [01]'
ignore_str="$ignore_str"'|error: status'
Copy link
Contributor

@lyakh lyakh Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that all error messages, containing the "error: status" substring will be ignored? That would seem overly broad to me.

Copy link
Collaborator

@marc-hb marc-hb Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lyakh for paying close attention. I think you're right BUT |error: status will be practically ignored only if it's alone or only with other lines ignored too. If at least one error line is not ignored then you get access to the entire kernel log for the corresponding test, @xiulipan confirm?

Copy link
Contributor Author

@xiulipan xiulipan Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think other real errors will still be caught.

ignore_str="$ignore_str"'|error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read'
;;
esac

Expand Down