ASoC: Intel: boards: tgl_sdw_rt5682: Add machine driver

[naveen-manohar]

TGL machine driver with RT5682 connected SNDW Link0 with HDMI Audio
& DMIC Support

Signed-off-by: Naveen Manohar naveen.m@intel.com

[naveen-manohar]

Patch for Debug Purposes Only

[kv2019i]

@naveen-manohar wrote:

Patch for Debug Purposes Only

Ack, I added "Draft-for-testing-not-ready-for-review" to inform people to not review this. Please remove the tag if you want to get reviews.

[plbossart]

@naveen-manohar could we look into reusing the same driver as for other SoundWire platforms?
The SOF driver will provide information telling the sdw_rt711_rt1308_rt715.c driver that there is an rt5682 on link1, so in theory all you need to do is provide a descriptor for that platform, and all the rest comes for free.

@RanderWang @bardliao now that I think of it, could we support the rt700 with the same machine driver, instead of maintaining sdw_rt700.c. That way we have a single machine driver for all SOF/SDW platforms.

[RanderWang]

@naveen-manohar could we look into reusing the same driver as for other SoundWire platforms?
The SOF driver will provide information telling the sdw_rt711_rt1308_rt715.c driver that there is an rt5682 on link1, so in theory all you need to do is provide a descriptor for that platform, and all the rest comes for free.

@RanderWang @bardliao now that I think of it, could we support the rt700 with the same machine driver, instead of maintaining sdw_rt700.c. That way we have a single machine driver for all SOF/SDW platforms.

yes, the sdw_rt711_rt1308_rt715 can support rt700 and 5682 or other sdw codecs with codec info added.

[lyakh]

alignment

[lyakh]

usleep_range()

[lyakh]

just do

if (ret)
	dev_err(...);

return ret;

[xiulipan]

@naveen-manohar May I ask what would be the soc-acpi-intel-tgl-match.c change? Can you give an example

[naveen-manohar]

@naveen-manohar could we look into reusing the same driver as for other SoundWire platforms?
The SOF driver will provide information telling the sdw_rt711_rt1308_rt715.c driver that there is an rt5682 on link1, so in theory all you need to do is provide a descriptor for that platform, and all the rest comes for free.

@RanderWang @bardliao now that I think of it, could we support the rt700 with the same machine driver, instead of maintaining sdw_rt700.c. That way we have a single machine driver for all SOF/SDW platforms.

@plbossart : Agreed, Let me try re-using sdw_rt711_rt1308_rt715.c for rt5682 at link0.. Its good thought to use single machine driver.

[naveen-manohar]

@naveen-manohar May I ask what would be the soc-acpi-intel-tgl-match.c change? Can you give an example

sound/soc/intel/common/soc-acpi-intel-tgl-match.c 
@@ -76,6 +76,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
		.sof_fw_filename = "sof-tgl.ri",
		.sof_tplg_filename = "sof-tgl-rt711-rt1308.tplg",
	},
	{
		.link_mask = 0x1, /* this will only enable rt5682 for now */
		.drv_name = "tgl_sdw_rt5682",
		.sof_fw_filename = "sof-tgl.ri",
		.sof_tplg_filename = "sof-tgl-rt5682.tplg",
	},

[RanderWang]

@naveen-manohar May I ask what would be the soc-acpi-intel-tgl-match.c change? Can you give an example

sound/soc/intel/common/soc-acpi-intel-tgl-match.c 
@@ -76,6 +76,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
		.sof_fw_filename = "sof-tgl.ri",
		.sof_tplg_filename = "sof-tgl-rt711-rt1308.tplg",
	},
	{
		.link_mask = 0x1, /* this will only enable rt5682 for now */
		.drv_name = "tgl_sdw_rt5682",
		.sof_fw_filename = "sof-tgl.ri",
		.sof_tplg_filename = "sof-tgl-rt5682.tplg",
	},

@naveen-manohar we add more features in mach table, can I update your patch and create a PR for you ?

[naveen-manohar]

Posted following patches based on PR:1889:
69b6d9b
0c92b28

[plbossart]

Replaced by #1912