Skip to content

RT5682 sdw unified mach #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kv2019i merged 2 commits into from
Mar 20, 2020
Merged

RT5682 sdw unified mach #1912

kv2019i merged 2 commits into from
Mar 20, 2020

Conversation

@naveen-manohar
Copy link

@naveen-manohar naveen-manohar commented Mar 19, 2020

Patch for Debug_Purposes..
Based on #1889

@naveen-manohar
Copy link
Author

naveen-manohar commented Mar 19, 2020

Apologize for posting RT5682 machine driver patches before PR:1889 Merge.

Wanted to discuss and get guidance about the following error that I observe with the patch-rebased to PR:1889, the same issue was not observed with PR:1885

  1. Jack Detection works fine
  2. Observe following error during playback
    LOG
    [ 94.622100] intel-sdw sdw-master-0: failed to set stream pointer on codec dai rt5682-aif1
    [ 94.622108] intel-sdw sdw-master-0: ASoC: can't open interface SDW0 Pin2: -524
    [ 94.622116] SDW0-Playback: ASoC: BE open failed -524
    [ 94.622121] SDW0-headphone: ASoC: failed to start some BEs -524
    [ 94.622128] SDW0-headphone: ASoC: BE playback disconnect check for SDW0-Playback
    [ 94.622130] SDW0-headphone: freed DSP playback path SDW0-headphone -> SDW0-Playback
    [ 94.622258] rt5682 sdw:0:25d:5682:0: Parity error detected
    [ 94.622519] intel-sdw sdw-master-0: Slave status change
    [ 112.360613] SDW0-headphone: ASoC: found 0 audio playback paths
    [ 112.360619] SDW0-headphone: ASoC: SDW0-headphone no valid playback route
    [ 112.360623] sof_sdw sof_sdw: ASoC: find BE for widget ALH2.OUT
    [ 112.360625] sof_sdw sof_sdw: ASoC: try BE : ALH2.OUT
    [ 112.360628] SDW0-headphone: connected new DPCM playback path SDW0-headphone -> SDW0-Playback
    [ 112.360651] SDW0-headphone: ASoC: found 1 new BE paths
    [ 112.360653] SDW0-Playback: ASoC: open playback BE SDW0-Playback

lyakh
lyakh requested changes Mar 19, 2020
View reviewed changes
@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from 0c92b28 to dd3d31b Compare March 19, 2020 14:03
@naveen-manohar naveen-manohar changed the title [WIP] RT5682 sdw unified mach RT5682 sdw unified mach Mar 19, 2020
@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from dd3d31b to 73fe6e2 Compare March 19, 2020 14:14
plbossart
plbossart requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naveen-manohar really pleased with this code. Minor comments below but that's really the direction we should follow.

@plbossart plbossart mentioned this pull request Mar 19, 2020
Closed
@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from 73fe6e2 to 3c95545 Compare March 19, 2020 18:11
@plbossart
Copy link
Member

plbossart commented Mar 19, 2020

@naveen-manohar please rebase on top of topic/sof-dev, thanks

plbossart
plbossart requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change in the Kconfig, otherwise ok once it's rebased

@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from 3c95545 to 1621191 Compare March 19, 2020 23:09
@naveen-manohar
Copy link
Author

naveen-manohar commented Mar 19, 2020

@naveen-manohar please rebase on top of topic/sof-dev, thanks

Done.. Thanks

plbossart
plbossart previously approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naveen-manohar, nice work.

RanderWang
RanderWang previously approved these changes Mar 20, 2020
View reviewed changes
lyakh
lyakh reviewed Mar 20, 2020
View reviewed changes
lyakh
lyakh reviewed Mar 20, 2020
View reviewed changes
sound/soc/intel/boards/sof_sdw_rt5682.c Outdated
Copy link
Collaborator

@lyakh lyakh Mar 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment below

lyakh
lyakh previously approved these changes Mar 20, 2020
View reviewed changes
kv2019i
kv2019i requested changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, code looks good. I do have a question about the first patch.. there's seems to be a disconnect between commit message and the changes. Please see inline.

@naveen-manohar naveen-manohar dismissed stale reviews from lyakh, RanderWang, and plbossart via abc6b03 March 20, 2020 09:38
@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from 1621191 to abc6b03 Compare March 20, 2020 09:38
@naveen-manohar naveen-manohar requested a review from kv2019i March 20, 2020 09:43
kv2019i
kv2019i previously approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naveen-manohar

@plbossart We ended up just updating the commit message and not splitting the patch. Please check again and if ok, let's merge.

@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from abc6b03 to 65b7046 Compare March 20, 2020 10:02
kv2019i
kv2019i previously approved these changes Mar 20, 2020
View reviewed changes
@naveen-manohar
ASoC: Intel: sof_sdw: Add Volteer support with RT5682 SNDW helper fun…
ce85c39 
…ction

Add support for Google Volteer device. As per new unified soundwire machine
driver, add rt5682-sdw helper function, which configures codec to Link0.

Signed-off-by: Naveen Manohar <naveen.m@intel.com>
@naveen-manohar
ASoC: Intel: common: add match table for TGL RT5682 SoundWire driver
50956f0 
RT5682 is in SoundWire mode on link0.

Signed-off-by: Naveen Manohar <naveen.m@intel.com>
plbossart
plbossart requested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the newline change is not good IMHO. We want the VOLUME keys handled as a separate block, and btw we should have the same style in different files, so if we change here for rt5682 we also change for RT711 and RT700

@naveen-manohar naveen-manohar force-pushed the rt5682-sdw_unified_mach branch from 65b7046 to 50956f0 Compare March 20, 2020 12:14
plbossart
plbossart approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do the newline removal in a followup PR for all jack codecs, for now this is good enough. Thanks @naveen-manohar

@kv2019i
Copy link
Collaborator

kv2019i commented Mar 20, 2020

Ok, if the newlines are ok, let's go ahead and merged. Only known CI failures in the report.

@kv2019i kv2019i merged commit 9b5b6c2 into thesofproject:topic/sof-dev Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossart plbossart plbossart approved these changes

@kv2019i kv2019i kv2019i approved these changes

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@lyakh lyakh Awaiting requested review from lyakh

@RanderWang RanderWang Awaiting requested review from RanderWang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naveen-manohar @plbossart @kv2019i @lyakh @RanderWang