Skip to content

Conversation

@xiulipan
Copy link

@xiulipan xiulipan commented Mar 28, 2020

Add new debug ABI version to be increased when changing user space debug
interfaces while the the main FW ABI is not affected.

The abi_dbg_version share same defination with SOF_ABI_VER

This change main ABI to 3.14.0

@ranj063
Copy link
Collaborator

ranj063 commented Mar 28, 2020

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@plbossart
Copy link
Member

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@lgirdwood was asking for separate PRs to help track changes with the ABI tool?

@ranj063
Copy link
Collaborator

ranj063 commented Mar 28, 2020

@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed.

@lgirdwood was asking for separate PRs to help track changes with the ABI tool?

oh I missed that memo possibly.

@mengdonglin mengdonglin added the ABI involves ABI changes, need extra attention label Mar 30, 2020
@kv2019i kv2019i requested review from lgirdwood and plbossart March 30, 2020 08:32
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan We need to stick to ABI classifier versions in the split PRs.
@lgirdwood This is getting quite complicated now....

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering whether we aren't overcomplicating things and whether we shouldn't stick to just one ABI version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh No idea of the usage model of this, but this discussion needs to happen on the FW side PR as the people involved are not reading this.

@xiulipan
Copy link
Author

@lgirdwood Ping here from thesofproject/sof#2522

Add new debug ABI version to be increased when changing user space debug
interfaces while the the main FW ABI is not affected.

The abi_dbg_version share same defination with SOF_ABI_VER

This change main ABI to 3.14.0

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@xiulipan
Copy link
Author

@kv2019i @lgirdwood Rebased and updated to ABI 14

@kv2019i kv2019i requested review from kv2019i and lyakh March 31, 2020 11:25
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiulipan ! I'll give reviewers a bit of time, wait for CI to complete and will then merge.

@lgirdwood
Copy link
Member

Travis build failure related to cpu_dai not being initialised in topology, checkpatch about types.

@lgirdwood
Copy link
Member

Jenkins showing IPC timeout on one APL variant, looks like a non 100% reproducible issue.

@lgirdwood lgirdwood merged commit 95a9868 into thesofproject:topic/sof-dev Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants