-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC: SOF: add debug ABI version #1947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xiulipan the first pacth is also in the previous pull request. Anyway, a single PR is good for both I think. The patches themselves look good but what's missing is the part where these ext data types are parsed. |
@lgirdwood was asking for separate PRs to help track changes with the ABI tool? |
oh I missed that memo possibly. |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiulipan We need to stick to ABI classifier versions in the split PRs.
@lgirdwood This is getting quite complicated now....
include/sound/sof/info.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering whether we aren't overcomplicating things and whether we shouldn't stick to just one ABI version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh No idea of the usage model of this, but this discussion needs to happen on the FW side PR as the people involved are not reading this.
|
@lgirdwood Ping here from thesofproject/sof#2522 |
Add new debug ABI version to be increased when changing user space debug interfaces while the the main FW ABI is not affected. The abi_dbg_version share same defination with SOF_ABI_VER This change main ABI to 3.14.0 Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
|
@kv2019i @lgirdwood Rebased and updated to ABI 14 |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiulipan ! I'll give reviewers a bit of time, wait for CI to complete and will then merge.
|
Travis build failure related to cpu_dai not being initialised in topology, checkpatch about types. |
|
Jenkins showing IPC timeout on one APL variant, looks like a non 100% reproducible issue. |
Add new debug ABI version to be increased when changing user space debug
interfaces while the the main FW ABI is not affected.
The abi_dbg_version share same defination with SOF_ABI_VER
This change main ABI to 3.14.0