Skip to content

ASoC: SOF: add debug ABI version #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Mar 31, 2020
Merged

ASoC: SOF: add debug ABI version #1947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions include/sound/sof/info.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ enum sof_ipc_ext_data {
SOF_IPC_EXT_WINDOW = 1,
SOF_IPC_EXT_CC_INFO = 2,
SOF_IPC_EXT_PROBE_INFO = 3,
SOF_IPC_EXT_USER_ABI_INFO = 4,
};

/* FW version - SOF_IPC_GLB_VERSION */
Expand Down Expand Up @@ -126,4 +127,11 @@ struct sof_ipc_probe_support {
uint32_t reserved[2];
} __packed;

/* extended data: user abi version(s) */
struct sof_ipc_user_abi_version {
struct sof_ipc_ext_data_hdr ext_hdr;

uint32_t abi_dbg_version;
Copy link
Collaborator

@lyakh lyakh Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering whether we aren't overcomplicating things and whether we shouldn't stick to just one ABI version

Copy link
Collaborator

@kv2019i kv2019i Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh No idea of the usage model of this, but this discussion needs to happen on the FW side PR as the people involved are not reading this.

} __packed;

#endif