ASoC: Intel: Boards: tgl_max98373: add dai_trigger function #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDharageswari
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
ranj063
reviewed
May 15, 2020
ranj063
reviewed
May 16, 2020
ranj063
reviewed
May 16, 2020
ranj063
reviewed
May 16, 2020
RDharageswari
force-pushed
the
sof_dev_15_05
branch
2 times, most recently
from
fbccb2b to
43bdcd2
Compare
ranj063
reviewed
May 16, 2020
RDharageswari
force-pushed
the
sof_dev_15_05
branch
from
43bdcd2 to
94d9263
Compare
plbossart
requested changes
May 16, 2020
Member
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
good start but this needs more work.
RDharageswari
force-pushed
the
sof_dev_15_05
branch
from
94d9263 to
0a65655
Compare
ranj063
reviewed
May 27, 2020
ranj063
reviewed
May 27, 2020
| case SNDRV_PCM_TRIGGER_STOP: | ||
| case SNDRV_PCM_TRIGGER_SUSPEND: | ||
| case SNDRV_PCM_TRIGGER_PAUSE_PUSH: | ||
| val = snd_soc_dai_active(codec_dai); |
Collaborator
There was a problem hiding this comment.
you dont seem to use val at all?
ranj063
reviewed
May 27, 2020
RDharageswari
force-pushed
the
sof_dev_15_05
branch
2 times, most recently
from
73f1579 to
c2759d5
Compare
ranj063
reviewed
May 28, 2020
RDharageswari
force-pushed
the
sof_dev_15_05
branch
from
c2759d5 to
9490dbd
Compare
ranj063
previously approved these changes
May 28, 2020
Collaborator
ranj063
left a comment
ranj063
left a comment
There was a problem hiding this comment.
Looks good, thanks @RDharageswari
plbossart
previously approved these changes
May 28, 2020
Member
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
If we ever want to work with a single amplifier the code will need to be updated, see below. It's not hypothetical, see ASoC: Intel: sof_da7219_max98373: Add support for max98360a speaker amp
Speaker amplifier feedback is not modeled as being dependent on any active output. Even when there is no playback happening, parts of the graph, specifically the IV sense->speaker protection->output remains active and this prevents the DSP from entering low-power states. This patch suggests a machine driver level approach where the speaker pins are enabled/disabled dynamically depending on stream start/stop events. DPAM graph representations show the feedback loop is indeed disabled and low-power states can be reached. Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
RDharageswari
force-pushed
the
sof_dev_15_05
branch
from
9490dbd to
8947163
Compare
ranj063
previously approved these changes
May 29, 2020
…onents MAX_98373_DEV0_NAME is the Right speaker and MAX_98373_DEV1_NAME is the Left speaker, hence updating the comments for max98373 dailink components accordingly. Signed-off-by: Dharageswari R <dharageswari.r@intel.com>
kv2019i
approved these changes
Jun 1, 2020
ranj063
approved these changes
Jun 1, 2020
plbossart
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speaker amplifier feedback is not modeled as being dependent on any
active output. Even when there is no playback happening, parts of the graph,
specifically the IV sense->speaker protection->output remains active and
this prevents the DSP from entering low-power states.
This patch suggest a machine driver level approach where the speaker
pins are enabled/disabled dynamically depending on stream start/stop
events. DPAM graph representations show the feedback loop is indeed
disabled and low-power states can be reached.