ICL ICCMAX support #2548
Merged
ICL ICCMAX support #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredoh9
requested review from
RanderWang,
bardliao,
dbaluta,
juimonen,
keyonjie,
kv2019i,
lgirdwood,
libinyang,
lyakh and
plbossart
as code owners
ranj063
reviewed
Oct 31, 2020
ranj063
reviewed
Oct 31, 2020
ranj063
reviewed
Oct 31, 2020
RanderWang
reviewed
Nov 2, 2020
RanderWang
reviewed
Nov 2, 2020
kv2019i
requested changes
Nov 2, 2020
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @fredoh9 ! Could we run some stress tests whether this PR helps with thesofproject/sof#3395 ? It would be really useful info and help to prioritize this PR.
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
d0ef6eb to
079992f
Compare
Collaborator
Author
I will run stress-test with this PR. I'm also curious about the result. |
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
079992f to
71d617d
Compare
fredoh9
commented
Nov 2, 2020
Collaborator
Author
|
I'm able to reproduce same error with the DEVICE TEST failure on ICL RVP. Looking at it. |
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
71d617d to
95d4873
Compare
ranj063
reviewed
Nov 3, 2020
ranj063
reviewed
Nov 3, 2020
ranj063
reviewed
Nov 3, 2020
ranj063
reviewed
Nov 3, 2020
ranj063
reviewed
Nov 3, 2020
fredoh9
force-pushed
the
fix/icl_iccmax
branch
2 times, most recently
from
d610910 to
ab2ec32
Compare
abonislawski
previously approved these changes
Nov 6, 2020
kv2019i
reviewed
Nov 6, 2020
sound/soc/sof/intel/Makefile
Outdated
Collaborator
There was a problem hiding this comment.
Btw, @ranj063 and @fredoh9 -- while ICCMAX is somewhat known as a concept, in this case this is a very specific and non-obvious quirk of our DSP bootflow. I won't complain now as the same text is already merged for TGL in upstream, but the commit message is not very helpful for people outside SOF project. But yeah, I'm ok to go with this The bit about "recommended hw programming sequence" is key and it's there...
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
ab2ec32 to
15edbec
Compare
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
15edbec to
e7d0a69
Compare
Collaborator
Author
|
@ranj063 I lost your approval after addressing Kai's comment. |
ranj063
previously approved these changes
Nov 10, 2020
Collaborator
Author
Sure, I will address that now! |
Add parse_platform_ext_manifest() op to parse platform-specific config data in the extended manifest. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Define the parse_platform_ext_manifest() op for HDA platforms to parse the SOF_EXT_MAN_CAVS_CONFIG_CAVS_LPRO config item to determine if the FW is configured for LPRO. The default clock configuration is assumed to be HPRO in the absence of this item in the extended manifest. New member clk_config_lpro is added to struct sof_intel_hda_dev to store the FW clock config information and that this will be used later to perform platform-specific operations in the post_fw_run op. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
OUTBOX_SIZE, INBOX_SIZE are defined but not being used yet. Handle these elements to avoid warning about unknown token type. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Modify the signature of stall op to specify core_mask to stall cores. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Separate the dsp ops for ICL ops to specify the use of ICCMAX FW boot sequence in the run op. All other ops are identical with TGL except post_fw_run. The recommended HW programming sequence for ICL is to power up core 3 and keep it in stall if HPRO is enabled. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
fredoh9
force-pushed
the
fix/icl_iccmax
branch
from
e7d0a69 to
a048f6a
Compare
kv2019i
approved these changes
Nov 12, 2020
ranj063
approved these changes
Nov 12, 2020
abonislawski
approved these changes
Nov 13, 2020
Collaborator
|
Ping @plbossart , you still have changes requested. Otherwise, I'm ready to press merge on this. |
This was referenced Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Nov 2,
First 3 commits are from PR 2297. Last a commit is for ICL ICCMAX support change.
Updated Nov 3,
First 3 commits are from PR 2297. Last four commits are for ICL ICCMAX support change.
For last commit, for explicit header inclusion. This is the right header required. This is valid style compliance fix per Documentation/process/submit-checklist.rst.
Updated Nov 4,
Dropped symatrical changes for other dsp interface.
Re-ordered and combining commits. Now last two are ICL ICCMAX change.