ALSA: hda: intel-dsp-config: add PCI id for TGL-H #2665
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
bardliao
changed the title
Currently, SOF is the only audio driver which supports TGL or EHL platforms. So we should select SOF driver unconditionally. Fixes: 82d9d54 ('ALSA: hda: add Intel DSP configuration / probe code') Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Adding PCI id for TGL-H and SOF will be the default audio driver. Signed-off-by: Bard Liao <bard.liao@intel.com>
|
@bardliao @xiulipan @libinyang I'm afraid this is not quite correct. Even for TGL, EHL and newer, the legacy driver should still be the default, unless Soundwire or DMIC is detected. |
|
@mengdonglin @plbossart Any clarify here? On TGL+ platforms, will SOF be default or SOF only if DMIC and SDW. |
@kv2019i Oops, I forgot legacy HDA driver. Can we revert 7c86362? |
|
The fixup PR is #2672. I am thinking someday we may need to detect I2S as well since SOF will be the default if I2S is using. |
| }, | ||
| { | ||
| .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, | ||
| .device = 0xa0c8, |
There was a problem hiding this comment.
No that's not correct. If we don't have DMIC/SoundWire, and it's not a Chromebook, then we want to use the legacy HDaudio driver.
The Chromebook does not rely on NHLT so the DMIC detection will fail, so it needs a dedicated quirk.
This needs to be reverted IMHO.
| { | ||
| .flags = FLAG_SOF, | ||
| .device = 0x43c8, | ||
| }, |
There was a problem hiding this comment.
same comment as above, this will unconditionally select SOF. This is not what we want.
7 participants
SOF driver will be selected if DMIC or SoundWire is used.
Signed-off-by: Bard Liao bard.liao@intel.com
Fixes: #2661