ALSA: hda: intel-dsp-config: add Alder Lake support #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rules to select SOF driver for Alder Lake systems if a digital microphone or SoundWire codecs are present in the system. This is following same rules as for older Tiger Lake systems. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
bardliao,
dbaluta,
lgirdwood,
plbossart and
ranj063
as code owners
Merged
Collaborator
Author
|
@plbossart I split this dspconfig to a separate PR so we can perhaps discuss the approach. E.g. do we still keep adding separate kconfig options for each Intel PCI SOF platform? It feels a bit odd to keep adding the same PCI ids to three places, all guarded by the same ifdefs. OTOH, this probably is orthogonal to adding ADL support as a change to this approach would apply to old platforms as well. |
lyakh
reviewed
Jan 11, 2021
| { | ||
| .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, | ||
| .device = 0x51c8, | ||
| }, |
Collaborator
There was a problem hiding this comment.
I think there were patches recently, enabling SOF on TGL unconditionally since SST doesn't support TGL. Does SST support ADL?
There was a problem hiding this comment.
@lyakh We talked about is TGL+, so I think NO for ADL here.
Collaborator
Collaborator
Author
xiulipan
approved these changes
Jan 11, 2021
ranj063
approved these changes
Jan 11, 2021
plbossart
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rules to select SOF driver for Alder Lake systems if a digital
microphone or SoundWire codecs are present in the system. This is
following same rules as for older Tiger Lake systems.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com