Skip to content

ALSA: hda: intel-dsp-config: add Alder Lake support #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Jan 13, 2021
Merged

ALSA: hda: intel-dsp-config: add Alder Lake support #2675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sound/hda/intel-dsp-config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,18 @@ static const struct config_entry config_table[] = {
},
#endif

/* Alder Lake */
#if IS_ENABLED(CONFIG_SND_SOC_SOF_ALDERLAKE)
{
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
.device = 0x7ad0,
},
{
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
.device = 0x51c8,
},
Copy link
Collaborator

@lyakh lyakh Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there were patches recently, enabling SOF on TGL unconditionally since SST doesn't support TGL. Does SST support ADL?

Copy link

@xiulipan xiulipan Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyakh We talked about is TGL+, so I think NO for ADL here.

Copy link
Collaborator

@bardliao bardliao Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there were patches recently, enabling SOF on TGL unconditionally since SST doesn't support TGL. Does SST support ADL?

My bad, #2665 is confusing people. @lyakh Legacy HDA driver should still be the default even if SST doesn't support ADL. See #2672

Copy link
Collaborator Author

@kv2019i kv2019i Jan 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack @bardliao @xiulipan , this is still needed to allow to select between non-DSP and DSP drivers.

It would be nice to avoid repeating all the PCI IDs here, but unless we change approach, this is not needed.

#endif

};

static const struct config_entry *snd_intel_dsp_find_config
Expand Down