ASoC: SOF: IPC4: add SRC module support #3692
Conversation
RanderWang
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ranj063,
ujfalusi and
yaochunhung
as code owners
|
updated commit message, thanks |
RanderWang
changed the title
RanderWang
changed the title
|
updated since topology thesofproject/sof#5913 is done. |
aiChaoSONG
left a comment
aiChaoSONG
left a comment
There was a problem hiding this comment.
This PR fix the schedule domain (LL/DP) issue on my side with the loadable dummy smart amp module.
|
Fixed typo, thanks! |
sound/soc/sof/ipc4-topology.h
Outdated
There was a problem hiding this comment.
where are these 2 definitions used?
There was a problem hiding this comment.
they are not used now, but may be in future. I prefer to add it by one shot
There was a problem hiding this comment.
I think it makes sense to add them when used
There was a problem hiding this comment.
I'm still not in favor of adding macros that are not yet used in this patch. But if everyone else is OK with it, please go ahead with it.
There was a problem hiding this comment.
It's not so bad, and it also explains why the LL/DP definitions don't start at zero.
RanderWang
force-pushed
the
ipc4-src
branch
2 times, most recently
from
dc0b07f to
15a3bf8
Compare
|
closed by mistake |
|
rebased code on latest commit |
|
Hi, @plbossart @ujfalusi @ranj063 , could you help to review this PR ? Thanks! |
|
@ranj063 please review/merge if ok |
|
@RanderWang conflict with Bard's changes, can you rebase, fix the conflict and push again? |
Dsp converts pcm rate to the one defined by dai. When SRC is used, the pcm runtime rate is different with dai rate and we need to fix it up for BE components. Signed-off-by: Rander Wang <rander.wang@intel.com>
SRC module only needs two parameters : base module config and sink rate. This patch adds prepare and setup for SRC widgets. Signed-off-by: Rander Wang <rander.wang@intel.com>
Currently the domain bit in ipc msg for module initialization is set to lp (low power) mode for pipeline. This is not correct since it is for module domain type: ll domain or dp domain which are for scheduler in fw. If the domain bit is set to 1 fw will process the module in dp domain or deal it with ll domain. So set domain bit based on dp domain setting. Signed-off-by: Rander Wang <rander.wang@intel.com>
|
rebased and validated. Thanks! |
| return 0; | ||
| err: | ||
| sof_ipc4_free_audio_fmt(&src->available_fmt); | ||
| kfree(src); |
There was a problem hiding this comment.
Only a nit-pick, but if you:
kfree(swidget->private);
swidget->private = NULL;
then the reader does not need to scroll up to see that swidget->private = src; in line 762.
There was a problem hiding this comment.
thanks. I want it to be consistent with above gain and mixer, so I did it.
6 participants
topology change: thesofproject/sof#5913