ASoC: SOF: Intel: pci-lnl: Change the topology path to intel/sof-ipc4… #4779
Conversation
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
…-tplg The firmware release which going to introduce support for Lunar Lake will use the documented default topology directory for IPC4: intel/sof-ipc4-tplg Change the default path accordingly before sof-bin (sof-firmware) release includes Lunar Lake firmware and topologies. Link: https://github.com/thesofproject/sof-docs/blob/master/getting_started/intel_debug/introduction.rst#2-topology-file Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
| }, | ||
| .default_tplg_path = { | ||
| [SOF_IPC_TYPE_4] = "intel/sof-ace-tplg", | ||
| [SOF_IPC_TYPE_4] = "intel/sof-ipc4-tplg", |
There was a problem hiding this comment.
For IPC4 are there any specific modifications in topology? Or just the file location?
Will IPC4 work with topology1 files?
Thanks!
There was a problem hiding this comment.
IPC4 needs topology2 files. We want to keep these separate as we might have platforms (officially) supported by both IPC3 (topology1) and IPC4 (topology2) in upstream.
There was a problem hiding this comment.
@iuliana-prodan @ujfalusi There's no strict dependency, you can write IPC3 tplgs with tplg1 or tplg2, and in reverse, you can write IPC4 tplgs with tplg1 or tplg2. That said, available common macro definitions to define pipelines limit the options so that currently you'll have to use tplg2 for IPC4 and tplg1 for IPC3.
UPDATE: so in short: "tplg1 == m4 preprocessing", "tplg2 == alsaconf preprocessing"
There was a problem hiding this comment.
@kv2019i, thanks for the correction!
But the same topology file cannot be used by IPC3 and IPC4, right?
There was a problem hiding this comment.
@ujfalusi Ack, the kernel will expect different entities in the tplg file for IPC3 and IPC4, so a single tplg file cannot provide both,.
There was a problem hiding this comment.
@kv2019i is there any example of tplg1 file working with IPC4?
There was a problem hiding this comment.
@iuliana-prodan Unfortunately no, all the Intel work for IPC4 was done with the tplg2 frontend.
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
Approval conditional on CI / daily tests passing.
|
@aiChaoSONG @ujfalusi please merge when all CI prerequisites are met. |
7 participants
…-tplg
The firmware release which going to introduce support for Lunar Lake will use the documented default topology directory for IPC4: intel/sof-ipc4-tplg
Change the default path accordingly before sof-bin (sof-firmware) release includes Lunar Lake firmware and topologies.
Link: https://github.com/thesofproject/sof-docs/blob/master/getting_started/intel_debug/introduction.rst#2-topology-file