Skip to content

ASoC: SOF: Intel: pci-lnl: Change the topology path to intel/sof-ipc4… #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bardliao merged 1 commit into from
Jan 22, 2024
Merged

ASoC: SOF: Intel: pci-lnl: Change the topology path to intel/sof-ipc4… #4779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sound/soc/sof/intel/pci-lnl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static const struct sof_dev_desc lnl_desc = {
[SOF_IPC_TYPE_4] = "intel/sof-ipc4/lnl",
},
.default_tplg_path = {
[SOF_IPC_TYPE_4] = "intel/sof-ace-tplg",
[SOF_IPC_TYPE_4] = "intel/sof-ipc4-tplg",
Copy link

@iuliana-prodan iuliana-prodan Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For IPC4 are there any specific modifications in topology? Or just the file location?

Will IPC4 work with topology1 files?

Thanks!

Copy link
Collaborator Author

@ujfalusi ujfalusi Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPC4 needs topology2 files. We want to keep these separate as we might have platforms (officially) supported by both IPC3 (topology1) and IPC4 (topology2) in upstream.

Copy link
Collaborator

@kv2019i kv2019i Jan 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iuliana-prodan @ujfalusi There's no strict dependency, you can write IPC3 tplgs with tplg1 or tplg2, and in reverse, you can write IPC4 tplgs with tplg1 or tplg2. That said, available common macro definitions to define pipelines limit the options so that currently you'll have to use tplg2 for IPC4 and tplg1 for IPC3.
UPDATE: so in short: "tplg1 == m4 preprocessing", "tplg2 == alsaconf preprocessing"

Copy link
Collaborator Author

@ujfalusi ujfalusi Jan 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i, thanks for the correction!
But the same topology file cannot be used by IPC3 and IPC4, right?

Copy link
Collaborator

@kv2019i kv2019i Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ujfalusi Ack, the kernel will expect different entities in the tplg file for IPC3 and IPC4, so a single tplg file cannot provide both,.

Copy link

@iuliana-prodan iuliana-prodan Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i is there any example of tplg1 file working with IPC4?

Copy link
Collaborator

@kv2019i kv2019i Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iuliana-prodan Unfortunately no, all the Intel work for IPC4 was done with the tplg2 frontend.

Copy link

@iuliana-prodan iuliana-prodan Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kv2019i, @ujfalusi

},
.default_fw_filename = {
[SOF_IPC_TYPE_4] = "sof-lnl.ri",
Expand Down