substitutions.txt: add missing |JSL|#211
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Apr 4, 2020
Merged
Conversation
Fixes commit f4ada42 ("getting_started: Add build documenation for ICL and JSL+") that added four "WARNING: Undefined substitution referenced: JSL" and for literal "|JSL|" instances on https://thesofproject.github.io/latest/getting_started/build-guide/build-from-scratch.html, example: Current target Intel platforms include: Bay Trail, Cherry Trail, Haswell, Broadwell, Apollo Lake, Cannon Lake, Ice Lake and |JSL|. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
dbaluta
approved these changes
Apr 3, 2020
Collaborator
Author
|
The other warnings are unrelated. Does github have the concept of a warning? It would be much better to make |
lgirdwood
approved these changes
Apr 3, 2020
Collaborator
Author
Not sure about github, but Travis apparently not. Travis is either green or red. I'm trying some experiment anyway in PR #214 if you're interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes commit f4ada42 ("getting_started: Add build documenation for
ICL and JSL+") that added four "WARNING: Undefined substitution
referenced: JSL" and for literal "|JSL|" instances on
https://thesofproject.github.io/latest/getting_started/build-guide/build-from-scratch.html,
example:
Signed-off-by: Marc Herbert marc.herbert@intel.com