Makefile: add ../sof/doc/doxygen/ dependency#212
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Apr 4, 2020
Merged
Makefile: add ../sof/doc/doxygen/ dependency#212lgirdwood merged 1 commit intothesofproject:masterfrom
lgirdwood merged 1 commit intothesofproject:masterfrom
Conversation
Doxygen is not incremental but it is super fast in this project with this configuration, so run it every time before we run sphinx. Totally negligible compared to the minutes required by plantUML.jar. Keep it optional not to add new dependencies. Now for users who opt-in, this commit will keep showing the doxygen warnings on every incremental build (unlike the .rst warnings unfortunately). Print the magic cmake invocation so no one has to go and read the build HOWTO to get (re)started. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
Collaborator
Author
|
The warnings are not new and unrelated. One of them will be fixed by PR #211 If/when this is gets merged then the Travis command can be simplified - assuming Travis can use ninja instead of Make. |
lgirdwood
approved these changes
Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doxygen is not incremental but it is super fast in this project with
this configuration, so run it every time before we run sphinx. Totally
negligible compared to the minutes required by plantUML.jar.
Keep it optional not to add new dependencies. Now for users who opt-in,
this commit will keep showing the doxygen warnings on every incremental
build (unlike the .rst warnings unfortunately).
Print the magic cmake invocation so no one has to go and read the build
HOWTO to get (re)started.
Signed-off-by: Marc Herbert marc.herbert@intel.com