Fix unit tests documentation #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain how to "steal" parameters from scripts/xtensa-build-all.sh Explain how to compile natively. Link the two sections with each other. `make platform_defconfig` was obsolete, replace with -DINIT_CONFIG Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
marc-hb
requested review from
cujomalainey,
dbaluta,
fredoh9,
kv2019i,
lyakh and
singalsu
dbaluta
approved these changes
Jul 23, 2021
singalsu
approved these changes
Jul 23, 2021
Collaborator
Author
... and that script unknown to me made me realize that what I wrote in this doc update is wrong: it is possible to run unit tests compiled with regular / host toolchain! In that case why would we not run these in CI?!? Fixed in: thesofproject/sof#4543 |
marc-hb
commented
Jul 26, 2021
| Example: Running tests for APL | ||
| ============================== | ||
| You can also compile the unit tests with your native compiler. You won't | ||
| be able to _run_ the tests but this can be convenient to test |
Collaborator
Author
There was a problem hiding this comment.
This is wrong, they can be run. Doc fix in #364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain how to "steal" parameters from scripts/xtensa-build-all.sh
Explain how to compile natively.
Link the two sections with each other.
make platform_defconfigwas obsolete, replace with -DINIT_CONFIGSigned-off-by: Marc Herbert marc.herbert@intel.com