Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jul 25, 2021

Skip the "alloc" test for now as it fails when built on the host (it passes and it is run with xt-run)

@marc-hb marc-hb changed the title github actions: run unit tests [SKIP CI] github actions: run unit tests Jul 25, 2021
@marc-hb marc-hb force-pushed the gh-unit-tests branch 4 times, most recently from 81641ba to bc41f51 Compare July 25, 2021 04:53
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 25, 2021

The "Misplaced SPDX-License-Identifier" is a checkpatch bug: it gets confused when the diff is at a certain distance from the top of the file.

marc-hb added 7 commits July 25, 2021 05:15
Fixes 'no previous prototype for trace_log_filtered' -Werr and
redefinition of ‘trace_flush_dma_to_mbox’ error.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This has been finding several pre-processing bugs already. Short of
randconfig some variety is the best we have.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Link to the CMake section in sof-docs which documents a lot of what this
script does and is probably out of date now. It would be less out of
date if this link had been there and more people had been aware that
this documentation even existed.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Before this it was required to find and run the executables one by one

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Adds --error-exitcode=1 to valgrind options (otherwise what's the point
of using valgrind?)

Skip alloc test that does not pass on HOST (passes with xt-run)

Add help message.

Runnable from anywhere.

Use shell functions
thesofproject/sof-test#740

Fix all quoting issues and other shellcheck warnings.

Add comments.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
It is failing and skipped only when compiled on the host, runs fine with
xt-run.

This is temporarily needed to add host-based unit tests to CI now and
catch any regression in any other test now.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Because we can.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 25, 2021

@marc-hb marc-hb requested review from singalsu and removed request for zrombel July 25, 2021 05:33
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 25, 2021

cc @ShriramShastry

@lgirdwood lgirdwood merged commit b63b8e9 into thesofproject:main Jul 26, 2021
@marc-hb marc-hb deleted the gh-unit-tests branch July 26, 2021 22:54
marc-hb added a commit to marc-hb/sof-docs that referenced this pull request Jul 26, 2021
... and now even CI does it since
thesofproject/sof#4543

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb added a commit to marc-hb/sof-docs that referenced this pull request Jul 26, 2021
... and now even CI does it since
thesofproject/sof#4543

Also mention run-cmocks.sh

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood pushed a commit to thesofproject/sof-docs that referenced this pull request Jul 27, 2021
... and now even CI does it since
thesofproject/sof#4543

Also mention run-cmocks.sh

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants