check-kmod-load-unload: remove hard-coded 10s timeout #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have a parameter for boot timeouts, let's use it. This enables kmod tests on MTL RVP. Closes: thesofproject#1037 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Collaborator
|
I think this is OK but looking in the test logs in https://sof-ci.01.org/softestpr/PR1044/build381/devicetest/index.html?model=CML_HEL_RT5682&testcase=check-kmod-load-unload and many others I think I found a bug in @fred09's fceeee0 : that commit has no |
Member
Author
Contributor
|
ah, that's right, this is critical bug in deed. |
Member
Author
|
Not sure if it's related but there's a weird result in https://sof-ci.01.org/linuxpr/PR4385/build5199/devicetest/index.html?model=CML_RVP_SDW&testcase=check-kmod-load-unload-after-playback. Somehow we already use the 70s even though this PR has not been merged. I can't figure this one out. |
btian1
reviewed
May 31, 2023
Collaborator
This is simply because commit fceeee0 runs ONCE, BEFORE EVERY test - including once before check-kmod-load-unload. The test had not really started yet in the logs you pointed at. |
Member
Author
Collaborator
Contributor
|
I will work on this, will provide a fix or ETA in this afternoon |
Collaborator
Collaborator
|
This can be merged after |
Collaborator
|
SOFCI TEST |
Collaborator
|
Unrelated suspend/resume failures in https://sof-ci.01.org/softestpr/PR1044/build505/devicetest/index.html, everything else green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a parameter for boot timeouts, let's use it. This enables kmod tests on MTL RVP.
Closes: #1037