lib.sh: make MAX_WAIT_FW_LOADING platform dependent #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to wait for 70s in every test on every platform when the firmware does not load. When multiplied by the number of tests in a plan this can cause a considerable waste of hardware resources. i915 timeout aside, 10s has proved over a long period to be more than enough. Fixes: thesofproject#1059 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Single, isolated suspend/resume failure in https://sof-ci.01.org/softestpr/PR1067/build493/devicetest/index.html?model=JSL_RVP_NOCODEC&testcase=check-suspend-resume-with-playback-5 Everything else green. |
fredoh9
approved these changes
Jun 26, 2023
Contributor
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
Looks good, thank you for the update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to wait for 70s in every test on every platform when the firmware does not load. When multiplied by the number of tests in a plan this can cause a considerable waste of hardware resources.
i915 timeout aside, 10s has proved over a long period to be more than enough.
Fixes: #1059