Skip to content

Conversation

@kv2019i
Copy link
Contributor

@kv2019i kv2019i commented Oct 22, 2020

Move CML specific mei_me error filters to platform specific
section and cover all three typical errors mei_me emits on
these devices.

Example CI run where error is seen in logs:
https://sof-ci.01.org/linuxpr/PR2518/build4747/devicetest/

BugLink: #389
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com

Move CML specific mei_me error filters to platform specific
section and cover all three typical errors mei_me emits on
these devices.

Example CI run where error is seen in logs:
https://sof-ci.01.org/linuxpr/PR2518/build4747/devicetest/

BugLink: thesofproject#389
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
# On CML_RVP_SDW, suspend-resume test case failed due to "mei_me 0000:00:16.4: hw_reset failed ret = -62" or with "hw_start" with same error code.
# https://github.com/thesofproject/sof-test/issues/389
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: hw_reset failed ret = -62'
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: hw_start failed ret = -62'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scripts uses a -E(xtended) expression so (reset|start) should work too if you prefer.

echo hw_start | grep -E 'hw_(reset|start)'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb I contemplated using that, but I guess there is value in keeping the text strings as verbatim copies of dmesg output, so when you search for errors you found in dmesg, you'll catch them more easily.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point... deserving a comment so no one comes in the future and "refines" this line with my suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb That applies to the whole file really, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i scores again. I will add this at the top.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I guess there is value in keeping the text strings as verbatim copies of dmesg output, so when you search for errors you found in dmesg, you'll catch them more easily.

Submitted (and A LOT more) as a guideline in #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants