Skip to content

sof-kernel-log-check.sh: finetune mei_me known error filtering #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marc-hb merged 1 commit into from
Oct 23, 2020
Merged

sof-kernel-log-check.sh: finetune mei_me known error filtering #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tools/sof-kernel-log-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ ignore_str='error: debugfs write failed to idle -16'
# https://bugzilla.kernel.org/show_bug.cgi?id=202541
ignore_str="$ignore_str"'|xhci_hcd 0000:00:14\.0: WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state'

# CML Mantis occasionally throws Intel(R) Management Engine Interface(mei) errors
# https://unix.stackexchange.com/questions/109294/mei-00000016-0-init-hw-failure
ignore_str="$ignore_str"'|mei_me 0000:00:16\.0: wait hw ready failed'
ignore_str="$ignore_str"'|mei_me 0000:00:16\.0: hw_start failed ret = -62'

# CML Mantis has DELL touchpad i2c error on suspend/resume
ignore_str="$ignore_str"'|i2c_designware i2c_designware\.0: controller timed out'
ignore_str="$ignore_str"'|i2c_hid i2c-DELL0955:00: failed to change power setting'
Expand Down Expand Up @@ -104,9 +99,14 @@ case "$platform" in
# Audio PCI ID on CML Mantis is [8086:9dc8], which is defined as CNL in linux kernel.
# https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/sof-pci-dev.c
icl|cml|cnl)
# On CML_RVP_SDW, suspend-resume test case failed due to "mei_me 0000:00:16.4: hw_reset failed ret = -62".
# On CML_RVP_SDW, suspend-resume test case failed due to "mei_me 0000:00:16.4: hw_reset failed ret = -62" or with "hw_start" with same error code.
# https://github.com/thesofproject/sof-test/issues/389
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: hw_reset failed ret = -62'
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: hw_start failed ret = -62'
Copy link
Collaborator

@marc-hb marc-hb Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scripts uses a -E(xtended) expression so (reset|start) should work too if you prefer.

echo hw_start | grep -E 'hw_(reset|start)'

Copy link
Contributor Author

@kv2019i kv2019i Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb I contemplated using that, but I guess there is value in keeping the text strings as verbatim copies of dmesg output, so when you search for errors you found in dmesg, you'll catch them more easily.

Copy link
Collaborator

@marc-hb marc-hb Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point... deserving a comment so no one comes in the future and "refines" this line with my suggestion?

Copy link
Contributor Author

@kv2019i kv2019i Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb That applies to the whole file really, right?

Copy link
Collaborator

@marc-hb marc-hb Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i scores again. I will add this at the top.

Copy link
Collaborator

@marc-hb marc-hb Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I guess there is value in keeping the text strings as verbatim copies of dmesg output, so when you search for errors you found in dmesg, you'll catch them more easily.

Submitted (and A LOT more) as a guideline in #470


# CML Mantis occasionally throws Intel(R) Management Engine Interface(mei) errors
# https://unix.stackexchange.com/questions/109294/mei-00000016-0-init-hw-failure
ignore_str="$ignore_str"'|mei_me 0000:00:16\..: wait hw ready failed'
;;
esac

Expand Down