multiple-pipeline: fix set -e compatibility and add it #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The shellcheck warnings in https://travis-ci.org/github/thesofproject/sof-test/jobs/741782133 predates this PR. The only test failure in https://sof-ci.01.org/softestpr/PR497/build367/devicetest is known bug thesofproject/sof#3462 and this test code change cannot cause this sort of failure, especially not on just one platform. |
xiulipan
previously requested changes
Nov 6, 2020
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR497/build372/devicetest is 100% successful and no shellcheck warning in https://travis-ci.org/github/thesofproject/sof-test/builds/742370356 is new |
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR503/build373/devicetest/?model=BYT_MB_NOCODEC&testcase=check-alsabat-headset-playback looks like thesofproject/sof#3462 again. This PR doesn't change this test |
Notably remove top-level "expr" because "expr 0" is surprisingly a failure and expr is antiquited anyway (SC2003) Progress towards thesofproject#312. Also add a dlogc() before killing so no one mistakes the deaths of aplay and arecord for failures. Add shellcheck source=case-lib/lib.sh, removes 5 warnings. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
aiChaoSONG
approved these changes
Nov 17, 2020
aiChaoSONG
left a comment
aiChaoSONG
left a comment
There was a problem hiding this comment.
LGTM, failures on APL and BDW is not related.
Collaborator
Author
|
This change broke the test in some configurations, tentative fix in #521 |
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Nov 18, 2020
... because its normal output is typically discarded. This would have avoided regression 202507f / thesofproject#497 fixed by thesofproject#521. This could help with other multi pipelines issues. Also add a documentation header so not everyone has to read the entire code. Also add a warning about the massive copy/paste across multiple-pipeline-playback and multiple-pipeline-capture (these are the heaviest sof-process-state users). Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Nov 18, 2020
... because its normal output is typically discarded. This would have avoided regression 202507f / thesofproject#497 fixed by thesofproject#521. This could help with other multi pipelines issues. Also add a documentation header so not everyone has to read the entire code. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Dec 1, 2020
... because its normal output is typically discarded. This would have avoided regression 202507f / thesofproject#497 fixed by thesofproject#521. This could help with other multi pipelines issues. Also add a documentation header so not everyone has to read the entire code. When a process is not found just say so. No need for guesses and interpretations. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
xiulipan
pushed a commit
that referenced
this pull request
Dec 1, 2020
... because its normal output is typically discarded. This would have avoided regression 202507f / #497 fixed by #521. This could help with other multi pipelines issues. Also add a documentation header so not everyone has to read the entire code. When a process is not found just say so. No need for guesses and interpretations. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably remove top-level "expr" because "expr 0" is surprisingly a
failure and expr is antiquited anyway (SC2003)
Also add a dlogi() before killing so no one mistakes the deaths of aplay
and arecord for failures.
Progress towards #312.
Signed-off-by: Marc Herbert marc.herbert@intel.com