add debug info in multiple-pipeline-playback/capture to root cause #472 #516
Conversation
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Please help review #497 (and others) first.
Also let's not add too much to the already ridiculous amount of copy/paste across these two files (they seem 90% identical!!!). You wrote a function so it should be re-usable without copy/paste/diverge...
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Sorry I just realized you are reducing copy/paste/diverge a bit: from 4 instances to 2 instances. How about finishing the job and going to just one instance?
|
@aiChaoSONG Ping for update, also rebase is needed. |
In these two cases, The variable tmp_count is used and modified everywhere, this is error-prone. This patch refine code structure, renames some variables and add some debug logs to root cause sof-test#472 Signed-off-by: Amery Song <chao.song@intel.com>
Signed-off-by: Amery Song <chao.song@intel.com>
This patch moves a common function func_error_exit to lib.sh to eliminate duplicated code in multiple-pipeline-playback.sh and multiple-pipeline- capture.sh Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
force-pushed
the
multi_pipeline
branch
from
baa4bff to
4ad1a26
Compare
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
try to use local in loops or functions to avoid wrong usage.
| sudo dmesg -C | ||
| # this variable is modified in func_run_pipeline_with_type, | ||
| # need to reassign at every iteration | ||
| tmp_count=$max_count |
There was a problem hiding this comment.
use local for the tmp_count if you do not want it to be used outside.
| aplay_count=$(pidof aplay | wc -w) | ||
| dlogi "$aplay_count playback process is running" | ||
| overall_count=$((arecord_count + aplay_count)) | ||
| [[ $overall_count -eq $max_count ]] || |
There was a problem hiding this comment.
use local for the overall_count
I screwed up #497, apologies. Tentative (and urgent) fix in #521. It's not practical to work on the same code at the same time because it will cause git conflicts. @aiChaoSONG please pause your work on the multiple pipelines tests for a couple days until I'm done with:
Once I'm all done I promise these tests will be all yours to deduplicate and clean-up! Appreciated. #521 should fix |
Submitted in #525 |
|
I think I got the root cause, see candidate fix in #538 |
|
@472 is already root caused and fixed, close. |
3 participants
No description provided.