-
Notifications
You must be signed in to change notification settings - Fork 59
Make multiple-pipeline-playback 99% identical to -capture again #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While making recent changes to multiple-pipeline-capture.sh I had vaguely noticed some similarities with multiple-pipeline-playback.sh but I had naively not realized that they were both an exact copy/paste of each other except for a couple lines. This commit make -playback catch up with recent -capture enhancements. It also makes them nearly identical again which is the first step before (painful) deduplication. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
As of November 18 the version of the (newer) -capture test this catches up to didn't have a single nightly test run yet. In other words this is not ready for merge yet. |
|
For https://sof-ci.01.org/softestpr/PR525/build412/devicetest/ APL_UP2_HDA was not available, everything else is PASS |
|
Except for the current shortage of APL_UP2_HDA , https://sof-ci.01.org/softestpr/PR525/build412/devicetest was successful. |
These two test scripts are really almost exactly the same. After #525 is merged and successfully tested over some period of quiet (and rare) CI time, the easiest next step is probably to replace them both with one-line wrappers like this:
#!/bin/bash
multiple-pipeline-common.sh --prefer playback "$@"
#!/bin/bash
multiple-pipeline-common.sh --prefer record "$@"cc: @ranj063 , @aiChaoSONG |
|
@marc-hb Do you consider to merge this two scripts to one and use a simple option for different test?
|
|
SOFCI TEST EDIT: only to get a bit one additional test round and some extra coverage with the latest version of everything. |
aiChaoSONG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
OK let's fast-track this, I think it's low-risk and it's blocking a number of next steps. |
|
Deduplication submitted in #532, not ready for merge today considering the other changes already merged today but 100% ready for review, thanks! |
While making recent changes to multiple-pipeline-capture.sh I had
vaguely noticed some similarities with multiple-pipeline-playback.sh but
I had naively not realized that they were both an exact copy/paste of
each other except for a couple lines. This commit make -playback catch
up with recent -capture enhancements. It also makes them nearly
identical again which is the first step before (painful) deduplication.
Signed-off-by: Marc Herbert marc.herbert@intel.com