journalctl patchset version 5 #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
force-pushed
the
pr/journalctlall
branch
from
9f79bbb to
e8fadd1
Compare
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
…iteration remove the redundant kernel log check for all case. enable kernel log check for each iteration. also do some clean up for this script Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
force-pushed
the
pr/journalctlall
branch
from
e8fadd1 to
9f78af5
Compare
…teration remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
…tion remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
…eration remove the redundant kernel log check for all case. enable kernel log check for each iteration. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
add some style options for the journalctl to unify all journalctl output format Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Directly use journalctl in the testcase to avoid kernel log missing issues. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
use journalctl by default for any kernel log reader usage. Also add headter for the file. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add path for the sof-dump-status.py to avoid error: sof-dump-status.py: command not found Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
use journalctl to get kernl logs. use timestamp as checkpoint to split logs for each test case. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add common error logs from systemd, initramfs, atkbd, i801_smbus, ata3, genirq, DMAR, dw_dmac, proc_thermal, SDWm, touch pad Those error level logs did not break functionality of the DUTs. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Contributor
Author
|
SOFCI TEST |
Contributor
Author
|
SOF CI test passed, merge now. Track issues in following tests. |
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Nov 24, 2020
This wasn't really a problem as long as sof-kernel-log-check.sh was reading /var/log/kernel.log, which just changed in PR thesofproject#529 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
|
For the record there a was an incomplete (and partially ignored) review in #509 and in some other PRs before that. |
marc-hb
added a commit
to marc-hb/sof-test
that referenced
this pull request
Nov 24, 2020
This was apparently missed in thesofproject#529 Together with thesofproject#523 this makes it identical to multiple-pipeline-capture.sh again. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
reviewed
Nov 24, 2020
| echo "$(date -u '+%Y-%m-%d %T %Z')" "[ERROR]" "Caught dmesg error" | ||
| # below are new error level kernel logs from journalctl --priority=err | ||
| # that did not influence system and can be ignored | ||
|
|
Collaborator
There was a problem hiding this comment.
Many of these errors are kernel errors. Why ignoring them was not required before / why is it required now?
Collaborator
There was a problem hiding this comment.
Answering my own question: because they don't have any "error" keyword in the message
|
|
||
| declare -p cmd | ||
| # check priority err for error message | ||
| [[ "$ignore_str" ]] && err=$($cmd --priority=err | grep -vE "$ignore_str") || $($cmd --priority=err) |
Collaborator
There was a problem hiding this comment.
The last part of this line is pretty clearly wrong. shellcheck reported this at the very bottom of https://travis-ci.org/github/thesofproject/sof-test/jobs/744836564 but of course shellcheck output is unreadable for such "big bang" pull requests.
Contributor
Author
There was a problem hiding this comment.
Will send a PR to fix this.
xiulipan
pushed a commit
that referenced
this pull request
Nov 24, 2020
This wasn't really a problem as long as sof-kernel-log-check.sh was reading /var/log/kernel.log, which just changed in PR #529 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This was referenced Dec 2, 2020
marc-hb
added
the
area:non-audio Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
kernel log dump and some test case dmesg usage.