sof-kernel-log-check: drop $journalctlflag duplicating journalctl_cmd() #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include case-lib/lib.sh and use journalctl_cmd() wrapper instead Signed-off-by: Marc Herbert <marc.herbert@intel.com>
xiulipan
approved these changes
Dec 3, 2020
Contributor
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
Thanks for the optimization.
| cmd="journalctl_cmd" | ||
| fi | ||
|
|
||
| declare -p cmd |
Contributor
There was a problem hiding this comment.
maybe it is also time to remove the debug log here.
Collaborator
Author
There was a problem hiding this comment.
#529 is less than one week old so I would rather wait a bit longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include case-lib/lib.sh and use journalctl_cmd() wrapper instead
Signed-off-by: Marc Herbert marc.herbert@intel.com