Skip to content

check-sof-logger: fail on empty logs #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marc-hb wants to merge 3 commits into from
Closed

check-sof-logger: fail on empty logs #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6834fe1
.github: remove workaround for out of date package index
marc-hb Mar 13, 2021
d7db7c0
check-sof-logger: fix some quoting and rephrase some errors
marc-hb Mar 13, 2021
54c4de0
check-sof-logger: fail when there's only the header
marc-hb Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ jobs:
# :-( https://github.bokerqi.topmunity/t/support-for-yaml-anchors/16128
- {uses: actions/checkout@v2, with: {fetch-depth: 0}}
- uses: actions/setup-python@v2
- name: temporary python3-pil HACK because github is out of date
run: sudo apt-get -y install libimagequant0 libwebpdemux2 &&
wget http://security.ubuntu.com/ubuntu/ubuntu/pool/main/p/pillow/python3-pil_7.0.0-4ubuntu0.2_amd64.deb &&
sudo dpkg -i python3-pil_*.deb
- name: get python libs
# FIXME: apt-get succeeds but 'import numpy' still fails!?
run: sudo apt-get -y install python3-numpy python3-scipy pylint
Expand Down
15 changes: 10 additions & 5 deletions test-case/check-sof-logger.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,23 +65,28 @@ func_logger_exit()
}

# check if we get any sof-logger errors
logger_err=`grep -i "error" $error_file`
logger_err=$(grep -i 'error' "$error_file")
if [[ $logger_err ]]; then
dloge "No available log to export due to sof-logger errors."
func_logger_exit 1 'error'
fi

# '\.c\:[1-9]' to filter like '.c:6' this type keyword like:
# [3017136.770833] (11.302083) c0 SA src/lib/agent.c:65 ERROR validate(), ll drift detected, delta = 25549
fw_log_err=`grep -i "error" $data_file | grep -v '\.c\:[1-9]'`
fw_log_err=$(grep -i 'error' "$data_file" | grep -v '\.c\:[1-9]')
data_len=$(wc -l < "${data_file}")

# '[[:blank:]]TIMESTAMP.*CONTENT$' to filter the log header:
# TIMESTAMP DELTA C# COMPONENT LOCATION CONTENT
if [[ ! $(sed -n '/[[:blank:]]TIMESTAMP.*CONTENT$/p' $data_file) ]]; then
dloge "No available log to export."
if [[ ! $(sed -n '/[[:blank:]]TIMESTAMP.*CONTENT$/p' "${data_file}") ]]; then
dloge "Log header not found in ${data_file}"
func_logger_exit 1
elif [[ "${data_len}" -lt 2 ]]; then
dloge "Nothing but the header in ${data_file}"
func_logger_exit 1
# we catch error from fw log
elif [[ $fw_log_err ]]; then
dloge "Errors in firmware log:"
dloge "Error(s) found in firmware log ${data_file}"
func_logger_exit 1
fi

Expand Down