Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Mar 13, 2021

1st commit:

fix some quoting and rephrase some errors
Get the number of shellcheck warnings down a bit.

2nd commit:

fail when there's only the header
Found by chance while testing Zephyr.

marc-hb added 3 commits March 12, 2021 18:39
... on Ubuntu VMs provided by github

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Get the number of shellcheck warnings down a bit.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Found by chance while testing Zephyr.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 13, 2021

https://github.com/thesofproject/sof-test/pull/629/checks?check_run_id=2100354934 has fewer shellcheck failures than before.

Interesting: the added test does fail on https://sof-ci.01.org/softestpr/PR629/build609/devicetest/?model=BYT_MB_NOCODEC&testcase=check-sof-logger

2021-03-13 02:55:42 UTC [REMOTE_ERROR] Nothing but the header in /home/ubuntu/sof-test/logs/check-sof-logger/2021-03-13-02:55:33-7598/logger.data.log

In the same run, https://sof-ci.01.org/softestpr/PR629/build609/devicetest/?model=BYT_MB_NOCODEC&testcase=check-playback-10sec has logs on the same system so the logger is not completely broken as it was in #294 / #297

@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 13, 2021

github fix superseded by PR 630

@marc-hb marc-hb changed the title Fail empty logs check-sof-logger: fail on empty logs Mar 13, 2021
@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 13, 2021

SOFCI TEST

@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 13, 2021

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

I took a longer look at the code and at #161 and #167 and realized the logic of this test does not make any sense.

There's an initial shellcheck cleanup without any functional change submitted in #659. Then I will submit a proper refactoring.

@marc-hb marc-hb closed this Apr 23, 2021
@marc-hb marc-hb added area:logs Log and results collection, storage, etc. False Pass / green failure labels Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logs Log and results collection, storage, etc. False Pass / green failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant