Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 23, 2021

Resubmit #383 to new main branch

Does not completely fixes #297 but goes a long way.

Signed-off-by: Marc Herbert marc.herbert@intel.com

Does not completely fixes thesofproject#297 but goes a long way.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

The less ambitious #629 passed except on BYT where it fails consistently

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

@marc-hb marc-hb marked this pull request as ready for review April 23, 2021 05:12
@marc-hb marc-hb requested a review from a team as a code owner April 23, 2021 05:12
Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that sof-logger is started by func_lib_start_log_collect in lib.sh, and some cases which only do kernel log check don't call this.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

and some cases which only do kernel log check don't call this.

if [ "X$SOF_LOG_COLLECT" == "X1" ]; then on line 27 should take care of that case. These tests would have failed otherwise.

Merging, if BYT (or other?) starts failing this test again then the #663 workaround should help.

@marc-hb marc-hb merged commit a207ff7 into thesofproject:main Apr 23, 2021
@marc-hb marc-hb deleted the no-empty-trace branch April 23, 2021 18:12
@marc-hb marc-hb added False Pass / green failure area:logs Log and results collection, storage, etc. labels Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logs Log and results collection, storage, etc. False Pass / green failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for a valid trace for ALL tests

2 participants