check-sof-logger: fix quoting, other shellcheck and rephrase errors #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2021
Hopefully no functional change. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
logger-shellcheck
branch
from
632a34f to
44bba1b
Compare
Collaborator
Author
|
APL_UP2_HDA was not available for https://sof-ci.01.org/softestpr/PR659/build675/devicetest/, everything else PASSED. |
fredoh9
approved these changes
Apr 26, 2021
Contributor
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
no functional change, let's merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully no functional change.
Signed-off-by: Marc Herbert marc.herbert@intel.com
https://sof-ci.01.org/softestpr/PR659/build670/devicetest (and everything else) is all green