Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 23, 2021

Two commits. Main one:

Increase default width from 10 to 12 to stop common misalignment,
especially in relative mode. New timestamp_width() function to avoid duplication and divergence.

Cosmetic change that does not fit in any other commit.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb changed the title logger: fix column and header aligments logger: fix column and header alignments Apr 23, 2021
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

check-sof-logger failed across all platforms in https://sof-ci.01.org/sofpr/PR4086/build8805/devicetest/ and I don't why yet.

https://sof-ci.01.org/sof-pr-viewer/#/build/PR4086/build6340913 is all green.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 23, 2021

https://sof-ci.01.org/sofpr/PR4086/build8815/devicetest/?model=APL_UP2_NOCODEC&testcase=check-suspend-resume-with-playback has the usual thesofproject/sof-test#650 TIMEOUT everything else passed.

EDIT: quickbuild never ran on 6c8333d (PTS-31119)

check-sof-logger failed across all platforms in https://sof-ci.01.org/sofpr/PR4086/build8805/devicetest/ and I don't why yet.

"Fixed" by adding whitespace before " TIMESTAMP". This check-sof-logger test has many flaws, I'm fixing them please help by reviewing preliminary cleanup thesofproject/sof-test#659

@marc-hb marc-hb marked this pull request as ready for review April 23, 2021 21:58
Comment on lines +283 to +298
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous version is capable to skip timestamp printing to allow easily use diff tool on logs, this commit removes this possibility

Copy link
Collaborator Author

@marc-hb marc-hb Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @ktrzcinx for the review. Fixed in 6c1a4cd.

PS: any idea why QB never tested 6c8333d ? (PTS-31119)

EDIT: https://sof-ci.01.org/sof-pr-viewer/#/build/PR4086/build6358153 is all green

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QB fails because of linking error in build with codec adapter:
src/audio/codec_adapter/codec/cadence.c.o:(.data+0x2c): undefined reference to "cadence_api_function"

So it looks unrelated to this PR

@marc-hb marc-hb marked this pull request as draft April 26, 2021 15:22
Increase default width from 10 to 12 to stop common misalignment,
especially in relative mode.

New timestamp_width() function to avoid duplication and
divergence.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review April 26, 2021 16:41
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 26, 2021

https://sof-ci.01.org/sofpr/PR4086/build8837/devicetest/?model=TGLH_RVP_HDA&testcase=check-suspend-resume-5 is the usual thesofproject/sof-test#650 TIMEOUT

In the same run, APL_UP2_HDA was not available. This PR has absolutely nothing APL specific and everything else passed.

QB is still on "vacation". It was successful for an older and not very different version of this PR, see above.

@fredoh9
Copy link
Contributor

fredoh9 commented Apr 26, 2021

@marc-hb do you have any example of misalignment log?

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 27, 2021

do you have any example of misalignment log?

Every time a timestamp is big, see first line below.

The other change in this PR is to remove the duplication. Adjusting these offsets is painful enough, better do that only in one place.

# sudo ~/bin/sof-logger  -l /lib/firmware/intel/sof/sof-apl.ldc -t  | head
         TIMESTAMP              DELTA C# COMPONENT          LOCATION                      CONTENT
[29745415112.708336] (        0.000000) c0 dma-trace             src/trace/dma-trace.c:393  ERROR FW ABI 0x3012001 DBG ABI 0x5003000 tag v1.2.4...
		 --- negative DELTA: wrap, IPC_TRACE, other? ---
[    37295.000000] (        0.000000) c0 ll-schedule        ./schedule/ll_schedule.c:398  task add 0xbe0572c0 dma-trace-task <2b972272...
[        5.208333] (        5.208333) c0 ll-schedule        ./schedule/ll_schedule.c:402  task params pri 4 flags 0 start 500000 period 500000

@lgirdwood
Copy link
Member

Jenkins showing a non booting DUT unrelated to this PR.

@lgirdwood lgirdwood merged commit d6f6a45 into thesofproject:main Apr 27, 2021
@marc-hb marc-hb deleted the logger-fix-width branch April 27, 2021 15:55
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 27, 2021

In (unrelated) #3925 we found by chance that QB applies patches not in git. A bad idea.

marc-hb added a commit to marc-hb/sof-test that referenced this pull request Apr 27, 2021
Need to be more flexible for changes like
thesofproject/sof#4086 or
thesofproject/sof#4105

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb added a commit to thesofproject/sof-test that referenced this pull request Apr 28, 2021
Need to be more flexible for changes like
thesofproject/sof#4086 or
thesofproject/sof#4105

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants