-
Notifications
You must be signed in to change notification settings - Fork 349
logger: fix column and header alignments #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cosmetic change that does not fit in any other commit. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
5f7f7d9 to
2c93f9a
Compare
|
check-sof-logger failed across all platforms in https://sof-ci.01.org/sofpr/PR4086/build8805/devicetest/ and I don't why yet. https://sof-ci.01.org/sof-pr-viewer/#/build/PR4086/build6340913 is all green. |
2c93f9a to
6c8333d
Compare
|
https://sof-ci.01.org/sofpr/PR4086/build8815/devicetest/?model=APL_UP2_NOCODEC&testcase=check-suspend-resume-with-playback has the usual thesofproject/sof-test#650 TIMEOUT everything else passed. EDIT: quickbuild never ran on 6c8333d (PTS-31119)
"Fixed" by adding whitespace before |
tools/logger/convert.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous version is capable to skip timestamp printing to allow easily use diff tool on logs, this commit removes this possibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks @ktrzcinx for the review. Fixed in 6c1a4cd.
PS: any idea why QB never tested 6c8333d ? (PTS-31119)
EDIT: https://sof-ci.01.org/sof-pr-viewer/#/build/PR4086/build6358153 is all green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QB fails because of linking error in build with codec adapter:
src/audio/codec_adapter/codec/cadence.c.o:(.data+0x2c): undefined reference to "cadence_api_function"
So it looks unrelated to this PR
Increase default width from 10 to 12 to stop common misalignment, especially in relative mode. New timestamp_width() function to avoid duplication and divergence. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
6c8333d to
6c1a4cd
Compare
|
https://sof-ci.01.org/sofpr/PR4086/build8837/devicetest/?model=TGLH_RVP_HDA&testcase=check-suspend-resume-5 is the usual thesofproject/sof-test#650 TIMEOUT In the same run, APL_UP2_HDA was not available. This PR has absolutely nothing APL specific and everything else passed. QB is still on "vacation". It was successful for an older and not very different version of this PR, see above. |
|
@marc-hb do you have any example of misalignment log? |
Every time a timestamp is big, see first line below. The other change in this PR is to remove the duplication. Adjusting these offsets is painful enough, better do that only in one place. |
|
Jenkins showing a non booting DUT unrelated to this PR. |
|
In (unrelated) #3925 we found by chance that QB applies patches not in git. A bad idea. |
Need to be more flexible for changes like thesofproject/sof#4086 or thesofproject/sof#4105 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Need to be more flexible for changes like thesofproject/sof#4086 or thesofproject/sof#4105 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Two commits. Main one:
Increase default width from 10 to 12 to stop common misalignment,
especially in relative mode. New timestamp_width() function to avoid duplication and divergence.