Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Apr 27, 2021

Also change <<END to ::END and print both files always.

<< and >> seem to corrupt the generated HTML and I could not find
anything parsing these anyway as of now.

See discussion in (much larger) PR #666 for more details.

Signed-off-by: Marc Herbert marc.herbert@intel.com

marc-hb added 2 commits April 27, 2021 16:46
Need to be more flexible for changes like
thesofproject/sof#4086 or
thesofproject/sof#4105

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Also change <<END to ::END and print both files always.

<< and >> seem to corrupt the generated HTML and I could not find
anything parsing these anyway as of now.

See discussion in (much larger) PR thesofproject#666 for more details.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 27, 2021

https://sof-ci.01.org/softestpr/PR668/build678/devicetest/?model=CML_RVP_SDW&testcase=check-sof-logger (nor any other platform) did not seem to mind the change from >> to ::.

@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 28, 2021

check-sof-logger test outputs in https://sof-ci.01.org/softestpr/PR668/build679/devicetest/ look fine except for the empty "logger" tabs but these tabs have been empty / broken for a long time, long before this PR. For instance they were already empty/broken in old and unrelated https://sof-ci.01.org/sofpr/PR3995/build8564/devicetest/?model=CML_HEL_RT5682&testcase=check-sof-logger

Log collection seems very complicated, see old discussion on that topic in internal gitlab issue 641

@marc-hb marc-hb marked this pull request as ready for review April 28, 2021 00:37
@marc-hb marc-hb requested a review from a team as a code owner April 28, 2021 00:37
Copy link

@aiChaoSONG aiChaoSONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, colon is good

@marc-hb marc-hb merged commit 11d0197 into thesofproject:main Apr 28, 2021
@marc-hb marc-hb deleted the BEG-HTML branch April 28, 2021 03:52
@marc-hb
Copy link
Collaborator Author

marc-hb commented Apr 28, 2021

Merged during the CI meeting. According to @aiChaoSONG there is no software expecting BEG, it looks like it but it's actually just for humans.

If incorrect then please revert quickly the BEG commit but please don't revert the other, regex and unrelated commit that is needed for thesofproject/sof#4105

@marc-hb marc-hb added the area:logs Log and results collection, storage, etc. label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logs Log and results collection, storage, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants