lib.sh: disable sof-logger when running IPC4 mode #882
Conversation
Currently, sof-logger is not supported when running IPC4 mode. Thus, disable SOF logs collection globally when DUT runs IPC4 mode. This should be removed after sof-logger support for IPC4 has been provided. Signed-off-by: Xiaoyun Wu(Iris) <xiaoyun.wu@intel.com>
|
this can replace PR https://github.com/intel-innersource/drivers.audio.ci.sof-sh/pull/53 and https://github.com/intel-innersource/drivers.audio.ci.sof-framework/pull/202. |
XiaoyunWu6666
requested review from
aiChaoSONG,
fredoh9,
greg-intel,
keqiaozhang,
marc-hb and
miRoox
| # 1: DUT runs IPC4 mode | ||
| ipc_type=$(cat $ipcFile) | ||
| if [ $ipc_type -eq 1 ]; then | ||
| dlogi "/sys/module/snd_sof_pci/parameters/ipc_type is ${ipc_type}, DUT runs IPC4 mode" |
There was a problem hiding this comment.
Sorry, by "runs" does it mean "will run in?" Or does it mean it ran in IPC4 mode? Current tense is ambiguous here and below.
There was a problem hiding this comment.
hi @greg-intel I modified the tense in #884 .
@plbossart Sorry, I mistook the repo . Already prepare a new PR from my own forked repo #884 , thx~
|
please submit PRs from your forked repository, not from a branch on the sof-test GIT tree. |
Currently, sof-logger is not supported when running IPC4 mode.
Thus, disable SOF logs collection globally when DUT runs IPC4 mode (this can be telled by system file /sys/module/snd_sof_pci/parameters/ipc_type).
This should be removed after sof-logger support for IPC4 has been provided.
Signed-off-by: Xiaoyun Wu(Iris) xiaoyun.wu@intel.com