Skip to content

lib.sh: disable sof-logger when running IPC4 mode #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XiaoyunWu6666 merged 1 commit into from
Mar 23, 2022
Merged

lib.sh: disable sof-logger when running IPC4 mode #884

XiaoyunWu6666 merged 1 commit into from
Mar 23, 2022

Conversation

@XiaoyunWu6666
Copy link
Contributor

@XiaoyunWu6666 XiaoyunWu6666 commented Mar 23, 2022

Currently, sof-logger is not supported when running IPC4 mode.

Thus, disable SOF logs collection globally when DUT runs IPC4 mode (this can be telled by system file /sys/module/snd_sof_pci/parameters/ipc_type).

This should be removed after sof-logger support for IPC4 has been provided.

Signed-off-by: Xiaoyun Wu(Iris) xiaoyun.wu@intel.com

@XiaoyunWu6666 XiaoyunWu6666 requested a review from a team as a code owner March 23, 2022 05:37
@XiaoyunWu6666 XiaoyunWu6666 changed the base branch from sof-logger-IPC4 to main March 23, 2022 05:38
@XiaoyunWu6666
Copy link
Contributor Author

XiaoyunWu6666 commented Mar 23, 2022

this can replace PR https://github.com/intel-innersource/drivers.audio.ci.sof-sh/pull/53 and https://github.com/intel-innersource/drivers.audio.ci.sof-framework/pull/202.
We make sof-test disable sof-logger directly when it detects ipc4 setting in system file , instead of passing the SOF_LOGGING variable to test framework or setting it as the environment variable

@XiaoyunWu6666 XiaoyunWu6666 mentioned this pull request Mar 23, 2022
Closed
aiChaoSONG
aiChaoSONG reviewed Mar 23, 2022
View reviewed changes
aiChaoSONG
aiChaoSONG reviewed Mar 23, 2022
View reviewed changes
case-lib/lib.sh Outdated
{
local ipc_type

ipcFile=/sys/module/snd_sof_pci/parameters/ipc_type
Copy link

@aiChaoSONG aiChaoSONG Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake case: ipc_file

aiChaoSONG
aiChaoSONG reviewed Mar 23, 2022
View reviewed changes
aiChaoSONG
aiChaoSONG reviewed Mar 23, 2022
View reviewed changes
@XiaoyunWu6666 XiaoyunWu6666 force-pushed the sof-logger-IPC4 branch 2 times, most recently from 6694d86 to a38a81d Compare March 23, 2022 08:29
@XiaoyunWu6666
lib.sh: disable sof-logger when running IPC4 mode
a38a81d 
Currently, sof-logger is not supported when running IPC4 mode.

Thus, disable SOF logs collection globally when DUT runs IPC4 mode.

This should be removed after sof-logger support for IPC4 has been
provided.

Signed-off-by: Xiaoyun Wu(Iris) <xiaoyun.wu@intel.com>
@XiaoyunWu6666
Copy link
Contributor Author

XiaoyunWu6666 commented Mar 23, 2022

test result on DUT is as expected

@XiaoyunWu6666 XiaoyunWu6666 merged commit dab6da8 into thesofproject:main Mar 23, 2022
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 24, 2022

Currently, sof-logger is not supported when running IPC4 mode.

@plbossart please correct me: I think this is wrong. sof-logger is not supported when running cAVS firmware. It should be supported when running open-source IPC4.

If a test fails with IPC4, how is the bug going to be identified without logs?

@aiChaoSONG
Copy link

aiChaoSONG commented Mar 24, 2022

@marc-hb I think the kernel doesn't setup debugfs for SOF under IPC4, so sof-logger can not work.

greg-intel
greg-intel reviewed Mar 24, 2022
View reviewed changes
case-lib/lib.sh
# TODO:
# Need to remove disabling sof-logger
# after sof-logger support for IPC4 has been provided in the future
dlogi 'Currenly sof-logger is not supported when running IPC4 mode'
Copy link
Contributor

@greg-intel greg-intel Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currenly should be Currently.

Sorry I didn't respond before the PR was merged.

marc-hb added a commit to marc-hb/sof-test that referenced this pull request May 13, 2022
@marc-hb
lib.sh: add missing quotes for $ipc_type
f56bb6e 
Fixes commit dab6da8 ("lib.sh: disable sof-logger when running IPC4
mode (thesofproject#884)")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb added a commit that referenced this pull request May 16, 2022
@marc-hb
lib.sh: add missing quotes for $ipc_type
0b61af1 
Fixes commit dab6da8 ("lib.sh: disable sof-logger when running IPC4
mode (#884)")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-hb marc-hb Awaiting requested review from marc-hb marc-hb is a code owner

@keqiaozhang keqiaozhang Awaiting requested review from keqiaozhang

@plbossart plbossart Awaiting requested review from plbossart

@fredoh9 fredoh9 Awaiting requested review from fredoh9

@miRoox miRoox Awaiting requested review from miRoox

@ranj063 ranj063 Awaiting requested review from ranj063

@RanderWang RanderWang Awaiting requested review from RanderWang

2 more reviewers

@greg-intel greg-intel greg-intel left review comments

@aiChaoSONG aiChaoSONG aiChaoSONG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XiaoyunWu6666 @marc-hb @aiChaoSONG @greg-intel