west.yml: Import cmsis_6 to be used by SOF for Cortex-M targets #10019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
A concise update to the manifest file to import the cmsis_6 dependency required for Cortex-M targets, specifically addressing the compilation error for SOF on IMX95.
- Imported cmsis_6 into the manifest
- Fixed compilation issues related to missing dependency
| - lz4 | ||
| - tinycrypt | ||
| - cmsis | ||
| - cmsis_6 |
There was a problem hiding this comment.
Ensure that including both 'cmsis' and 'cmsis_6' is intentional; if they serve different purposes, consider adding a clarifying comment to explain their roles.
Contributor
There was a problem hiding this comment.
Based on this commit zephyrproject-rtos/zephyr@f726cb5123eda12fe I would say that cmsis_6 is enough for SOF since we only support Cortex M (no Cortex A/R which uses cmsis).
So, please change cmsis with cmsis_6.
dbaluta
force-pushed
the
fix_m_build
branch
2 times, most recently
from
1ef4c94 to
0c737b6
Compare
After commit
f726cb5123eda ("modules: CMSIS_6: Switch to CMSIS_6 for Cortex-M")
SOF needs cmsis_6 to be used for Cortex-M (imx95).
So import cmsis_6 and fix the compilation error.
Since we only support Cortex-M targets (no Cortex A/R) let's get rid of
cmsis import to reduce import time.
Fixes: thesofproject#10014
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
kv2019i
approved these changes
May 19, 2025
iuliana-prodan
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit
f726cb5123eda12fe ("modules: CMSIS_6: Switch to CMSIS_6 for Cortex-M") SOF needs cmsis_6 to be used for Cortex-M (imx95).
So import cmsis_6 and fix the compilation error.
Fixes: #10014