Skip to content

zephyr: audio: host: Fix "no bytes to copy" log supressing #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jun 27, 2025
Merged

zephyr: audio: host: Fix "no bytes to copy" log supressing #10068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/audio/host-zephyr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,25 +454,24 @@ static uint32_t host_get_copy_bytes_normal(struct host_data *hd, struct comp_dev
if (!(hd->ipc_host.feature_mask & BIT(IPC4_COPIER_FAST_MODE)))
dma_copy_bytes = MIN(hd->period_bytes, dma_copy_bytes);

bool reset_skipped = false;
uint64_t now = k_uptime_get();
uint64_t delta = now - hd->nobytes_last_logged;
const uint64_t now = k_uptime_get();
const uint64_t delta = now - hd->nobytes_last_logged;
const bool reset_skipped = delta > SOF_MIN_NO_BYTES_INTERVAL_MS;

if (hd->n_skipped > 1 && (dma_copy_bytes || reset_skipped)) {
comp_warn(dev, "Skipped %u no-bytes events in last %llu ms, bytes %u",
hd->n_skipped - 1, delta, dma_copy_bytes);
hd->n_skipped = 0;
}

if (!dma_copy_bytes) {
if (delta > SOF_MIN_NO_BYTES_INTERVAL_MS) {
if (!hd->n_skipped || reset_skipped) {
Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider restructuring the incrementation of hd->n_skipped by moving the increment into an else clause. This would clarify that the increment is intended only when no logging occurs, improving readability.

Copilot uses AI. Check for mistakes.
hd->nobytes_last_logged = now;
comp_warn(dev, "no bytes to copy, available samples: %d, free_samples: %d",
hd->n_skipped = 0;
comp_warn(dev, "no bytes to copy, available samples: %u, free_samples: %u",
avail_samples, free_samples);
reset_skipped = true;
} else {
hd->n_skipped++;
}
}

if (hd->n_skipped && (reset_skipped || dma_copy_bytes)) {
comp_warn(dev, "Skipped %u no-bytes events in last %llu ms",
hd->n_skipped, delta);
hd->n_skipped = 0;
hd->n_skipped++;
}

/* dma_copy_bytes should be aligned to minimum possible chunk of
Expand Down
Loading