sof: logger: reopen trace file upon EOF #1312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If logger reads an end-of-file from trace node, reopen the file to ensure trace read position is in sync between host and DSP. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
lgirdwood
approved these changes
Apr 24, 2019
keyonjie
approved these changes
Apr 25, 2019
Contributor
keyonjie
left a comment
keyonjie
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing this.
Member
|
@zrombel not sure why CI test would fail as this PR is for a python script used to view trace. |
|
PR was rebuild and all tests pass. It was a server issue. |
jajanusz
approved these changes
Apr 25, 2019
marc-hb
reviewed
Sep 15, 2020
| if (!ret) { | ||
| if (config->trace) | ||
| if (config->trace && !ferror(config->in_fd)) { | ||
| freopen(NULL, "r", config->in_fd); |
Collaborator
There was a problem hiding this comment.
Ignored returned value reported by gcc 9.3 -Werr, fixed in #3412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If logger reads an end-of-file from trace node, reopen the file
to ensure trace read position is in sync between host and DSP.
This allows to avoid duplicate/misordered traces at suspend/resume cycles when used together with PR781 thesofproject/linux#781
This patch can be merged independently of PR781, there is no hard dependency.