logger: fix CMAKE_BUILD_TYPE=Release build #3412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by gcc 9.3.0-10ubuntu2 and VERBOSE=1 CMAKE_BUILD_TYPE=Release ./scripts/build-tools.sh -l ‘__builtin___snprintf_chk’ output between 23 and 57 bytes into a time_fmt destination of size 32 Fixes commit d7b535e ("logger: Add option to set timestamp precision") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reported by VERBOSE=1 CMAKE_BUILD_TYPE=Release ./scripts/build-tools.sh -l and gcc version 9.3.0-10ubuntu2. out_fd is not initialized on the first "goto err:" and this can result in trying to close a random file descriptor. Fixes commit 126060a ("logger: Send parsed runtime log levels to FW via debugFS") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Reported by VERBOSE=1 CMAKE_BUILD_TYPE=Release ./scripts/build-tools.sh -l and gcc version 9.3.0-10ubuntu2: tools/logger/convert.c:630:5: error: ignoring return value of ‘freopen’, declared with attribute warn_unused_result [-Werror=unused-result] Tested with sof-test/test-case/check-suspend-resume-with-audio.sh Fixes commit 6a84b4e ("sof: logger: reopen trace file upon EOF") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
akloniex,
bkokoszx and
xiulipan
as code owners
marc-hb
requested review from
andyross,
cujomalainey,
dbaluta,
ktrzcinx,
lgirdwood and
singalsu
This was referenced Sep 15, 2020
ktrzcinx
approved these changes
Sep 15, 2020
cujomalainey
approved these changes
Sep 15, 2020
lgirdwood
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits, see commit messages below.
All2 out the 3 warnings fixed by this are shown in https://travis-ci.org/github/thesofproject/sof/jobs/727258703 (for other PR #3411 )After this,
CMAKE_BUILD_TYPE=Release ./build-tools.shbuilds everything successfully.