Logger add possibility to make logs output more compact #2905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaka1
approved these changes
May 4, 2020
lgirdwood
reviewed
May 7, 2020
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Can you give before/after examples in the commit messages. Thanks.
Member
Author
|
@lgirdwood updated |
Member
|
@ktrzcinx the updates look good, but I mean paste the before/after into the commit message not the PR message. This way it's obvious for anyone reading the git logs as the current messages are vague. |
Member
Author
|
@lgirdwood updated |
dbaluta
reviewed
May 8, 2020
It allows to make logs output more compact, it change:
$ ./sof-logger -l sof-cnl.ldc -i dma_trace_1.bin
TIMESTAMP DELTA C# COMPONENT LOCATION CONTENT
[ 497588.489583] ( 497588.500000) c0 DMA .../intel/cavs/hda-dma.c:407 hda-dmac: 4 channel 6 -> get
to:
$ ./sof-logger -l sof-cnl.ldc -i dma_trace_1.bin -L
TIMESTAMP DELTA C# COMPONENT CONTENT
[ 497588.489583] ( 497588.500000) c0 DMA hda-dmac: 4 channel 6 -> get
Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Shorten timestamp makes logger output more compact, it change:
$ ./sof-logger -l sof-cnl.ldc -i dma_trace_1.bin
TIMESTAMP DELTA C# COMPONENT LOCATION CONTENT
[ 497588.489583] ( 497588.500000) c0 DMA .../intel/cavs/hda-dma.c:407 hda-dmac: 4 channel 6 -> get
to:
$ sof-logger -l sof-cnl.ldc -i dma_trace_1.bin -f0
TIMESTAMP DELTA C# COMPONENT LOCATION CONTENT
[ 497588] ( 497588) c0 DMA .../intel/cavs/hda-dma.c:407 hda-dmac: 4 channel 6 -> get
Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Member
|
@ktrzcinx can you double check CI, it looks like the build has failed ? Seems unrelated to this ? |
Member
Author
and So nothing related with logger, especially when I added functionality is disabled in CI tests (need to pass extra flags) |
marc-hb
reviewed
Sep 15, 2020
| snprintf(time_fmt, sizeof(time_fmt), | ||
| "%%s[%%%d.%df] (%%%d.%df)%%s ", | ||
| float_precision + 10, float_precision, | ||
| float_precision + 10, float_precision); |
Collaborator
There was a problem hiding this comment.
With a crazy long precision snprintf can truncate time_fmt. Reported by gcc 9.3 -Werr and fixed in PR 3411 #3412 sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to set timestamp precision and second one to cutout trace location
Original output:
With flag -L:
With flag -L -f0: