DMIC topology updates patch set #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch restores the missing configuration into macro intel-generic-dmic.m4. Without this patch the 48 kHz DMIC DAI is not created. Both DMIC FIFOs are available at any channels number and PCM format so there is no need to delete a DAI when 4ch configuration is used. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch changes the secondary DMIC FIFO configuration into 32 bits mode for better quality. Since there is volume component in DMIC capture pipelines the conversion to other PCM formats can happen there. Using volume controller with 32 bit input gives a lot better audio quality when the microphone signal needs amplification. The scheduling of 16 kHz DAI is changed to 1000us. The comment of 1000 us is correct but the parameter 48 is not. With 16 frames the scheduling becomes the desired. This change should also save some RAM due to smaller buffers. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
@lgirdwood I guess I need to make this same PR for cml-hda-dmic-001-drop-stable, right? |
Contributor
|
@singalsu no need, just focus on master, if SW side will let us know that they need something for that drop I'll just rebase/cherry-pick |
Collaborator
Author
|
@jajanusz I just did, I'll close the other PR. Thanks! |
jajanusz
approved these changes
May 28, 2019
RanderWang
reviewed
May 28, 2019
RanderWang
approved these changes
May 29, 2019
Collaborator
RanderWang
left a comment
RanderWang
left a comment
There was a problem hiding this comment.
I tested it on whiskylake.
Collaborator
Author
|
@RanderWang Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set consists of two commits