Skip to content

probes: Add extended boot data regarding probes support. #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jajanusz merged 2 commits into from
Feb 11, 2020
Merged

probes: Add extended boot data regarding probes support. #2338

jajanusz merged 2 commits into from
Feb 11, 2020

Conversation

@akloniex
Copy link
Member

@akloniex akloniex commented Jan 30, 2020

Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com

@akloniex akloniex added the ABI ABI change involved label Jan 30, 2020
jajanusz
jajanusz suggested changes Jan 30, 2020
View reviewed changes
@akloniex akloniex requested a review from jajanusz January 30, 2020 13:15
lgirdwood
lgirdwood requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to take care of the section attributes for the SRAM window, CC info structurse too in a new patch.

lgirdwood
lgirdwood requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs the section updates for this data too.

@akloniex akloniex requested a review from lyakh as a code owner February 5, 2020 00:16
@akloniex
Copy link
Member Author

akloniex commented Feb 5, 2020

@lgirdwood I've created new section .fw_ready_metadata to store extended boot messages and updated linker scripts to append that to .fw_ready section. This way we keep struct sof_ipc_fw_ready body as first member of that section to maintain proper section layout, so that it shouldn't cause any issues with veriosn verification in sof-logger.

@akloniex akloniex requested a review from lgirdwood February 5, 2020 00:20
lgirdwood
lgirdwood requested changes Feb 5, 2020
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this series need squashed as the second patch undoes part of the first patch.

@akloniex akloniex requested a review from lgirdwood February 5, 2020 14:47
@lgirdwood
Copy link
Member

lgirdwood commented Feb 6, 2020

@akloniex can you take a quick look at checkpatch, not sure if it's attributes warnings are valid for XCC ?

@jajanusz
Copy link
Contributor

jajanusz commented Feb 7, 2020

@akloniex can you take a quick look at checkpatch, not sure if it's attributes warnings are valid for XCC ?

They are not valid for our project. We don't even have this macro and I'm not sure if we should introduce it. We don't have also __packed f.e. as we can't use these in abi headers. So I guess it's better to just leave attribute everywhere instead of porting part of kernel macros.

jajanusz
jajanusz suggested changes Feb 7, 2020
View reviewed changes
@akloniex
probes: Add extended boot data regarding probes support.
19b9c3d 
Create compile-time section .fw_ready_metadata and append it to
.fw_ready with linker.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex
boot metadata: Move mem window and cc version info to .fw_ready section.
db12b2c 
Move extended boot metadata structures to compile-time section
.fw_ready_metadata which is appended to .fw_ready section of binary.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@akloniex akloniex requested a review from jajanusz February 10, 2020 12:42
@jajanusz jajanusz merged commit cb813bb into thesofproject:master Feb 11, 2020
@akloniex akloniex deleted the probes-interface branch February 11, 2020 10:57
This was referenced Mar 24, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@plbossart plbossart Awaiting requested review from plbossart

@crojewsk crojewsk Awaiting requested review from crojewsk

@lbetlej lbetlej Awaiting requested review from lbetlej

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@abonislawski abonislawski Awaiting requested review from abonislawski

@bardliao bardliao Awaiting requested review from bardliao

@dbaluta dbaluta Awaiting requested review from dbaluta

@RanderWang RanderWang Awaiting requested review from RanderWang

@tlauda tlauda Awaiting requested review from tlauda

@xiulipan xiulipan Awaiting requested review from xiulipan

@lyakh lyakh Awaiting requested review from lyakh

+1 more reviewer

@jajanusz jajanusz jajanusz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ABI ABI change involved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akloniex @lgirdwood @jajanusz