[RFC]align mismatch ABI in info.h #1929
Conversation
Add new probe support extend date to show the probe support info. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add new debug ABI version to be increased when changing user space debug interfaces while the the main ABI is not affected. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
requested review from
dbaluta,
juimonen,
keyonjie,
lyakh and
ranj063
as code owners
|
@plbossart @lgirdwood I will add printk that use this ABI update later. |
| } __packed; | ||
|
|
||
| /* extended data: user abi version(s) */ | ||
| struct sof_ipc_user_abi_version { |
There was a problem hiding this comment.
"user abi" is a bit weird name, but alas this was already merged to FW, so it's what it is.
| SOF_IPC_EXT_UNUSED = 0, | ||
| SOF_IPC_EXT_WINDOW = 1, | ||
| SOF_IPC_EXT_CC_INFO = 2, | ||
| SOF_IPC_EXT_PROBE_INFO = 3, |
There was a problem hiding this comment.
@lgirdwood @jajanusz It really would be better to do the kernel PRs at the same time and have the person doing the change write a git commit message that explains the change. This "late-bound" sync of changes to kernel is not fun. Thanks for @xiulipan doing the patch, but I again have to ask for some improvements to the commit message:
- "add support for probe extended data"
- add explanation to commit body about the feature.. you should be able to copy this from the FW commit
There was a problem hiding this comment.
agree with @kv2019i , this is a complete fail of the ABI change process.
There was a problem hiding this comment.
The kernel and FW PRs must be done together and mention each other. It is up to maintainers to label as ABI and then to align both PRs using the classifier. So this is several steps taken by at least 3 people and is not being fully processed by everybody.
I am now wondering whether we should now be moving to a ABI minor bump only for every FW release (when the regular FW releases start soon). This would allow the kernel team to plan each merge window in advance to a specific FW version. @lbetlej fyi - regular FW releases would help here.
There is also complexity about bumping ABI in relation to kernel releases and FW releases. i.e. when do we close the ABI minor merge window for new kernel and FW releases (and use the next minor).
xiulipan
changed the title
|
@plbossart @lgirdwood @kv2019i To make ABI version bump in order, I will close this PR and merge the ABI patch into #1890 |
4 participants
Add probe support from thesofproject/sof#2338
Add debug ABI version from thesofproject/sof#2398
bump ABI to 3.14.0
Need by #1890