abi: define debug abi version for user space dbg interfaces #2398
Conversation
mmaka1
requested review from
a team,
RanderWang,
akloniex,
bardliao,
bkokoszx,
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
plbossart,
tlauda and
xiulipan
as code owners
|
Implements #2374 |
rimage/file_simple.c
Outdated
There was a problem hiding this comment.
I feel like the separating out of this function can be its own patch.
There was a problem hiding this comment.
If it were just refactor, then yea. But here you'd have 1 diff to have it changed in another.
|
Do we need corresponding kernel PR for this one ? |
@lgirdwood I tested with unchanged kernel and seems to work fine. Another fw_ready extension does not break compatibility, therefore I increased 'minor' component only in the main ABI before aligning initial debug ABI version with the main one. |
Ok great, @plbossart good for you ? or would you need a patch that printk() the ABI version for userspace debug ? |
|
SOFCI TEST |
|
Quickbuild changes are causing some problems, sorry for that. When it will be fixed I will rebuild this PR. |
|
QB is back on track. Build and tests passed. |
src/include/user/abi_dbg.h
Outdated
There was a problem hiding this comment.
Is 'debug abi' the best name for this? We have folders that are named by-abi-user (kernelspace or userspace), but ABI version symbols are named by-feature (generic vs debug).
There was a problem hiding this comment.
Nvm, I see it's going to be more granular for user, versions are in sof_ipc_user_abi_version
|
|
|
@mmaka1 can u fix checkpatch issue? |
|
@lgirdwood As we are trying to update the GitHub behind a proyx, there is always some chance that the status update is missed. Will try to add some more strict check to see if we can use retry or other method to avoid such issue. |
The sof-logger and potentially other debug API clients perform ABI compatibility check using the single FW ABI version. The same one is used by the primary FW client which is the kernel driver. If there is a change made to the debug API, the main ABI has to be updated to protect integrity of the debug tools while such a change may not affect the kernel driver at all. This patch introduces new debug ABI version to be increased when changing user space debug interfaces while the the main ABI is not affected. Recompilation and installation of the new driver every time the tunneled debug protocol is upgraded may be avoided. Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
|
@jajanusz I fixed the alignment issue. Another one be fixed is the |
|
@zrombel we have a DMIC CI failure on ICL, but it should be unrelated to this patch ? |
|
@lgirdwood Aside from SSP KD tests failing due to regression on master (should be fixed by #2440) this looks good to be merged. |
|
SOFCI TEST |
|
@wwittbrx running CI again now that Jenkins has had some fixes too. |
8 participants
The sof-logger and potentially other debug API clients perform ABI
compatibility check using the single FW ABI version. The same one is used
by the primary FW client which is the kernel driver. If there is a change
made to the debug API, the main ABI has to be updated to protect integrity
of the debug tools while such a change may not affect the kernel driver
at all.
This patch introduces new debug ABI version to be increased when changing
user space debug interfaces while the the main ABI is not affected.
Recompilation and installation of the new driver every time the tunneled
debug protocol is upgraded may be avoided.
Signed-off-by: Marcin Maka marcin.maka@linux.intel.com