detect_test: add notification to the list if channel busy #2440
Conversation
tlauda
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
|
@lgirdwood This should fix internal CI, however some major refactor of IPC notifications is needed. I'll try to take care of it. |
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Do the other platform specific IPC drivers have to adjust? I see no adjustment in the i.MX specific IPC implementation and I think there are others as well.
Adds notification to the beginning of the list if there is some other IPC notification being sent. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
With this change no. |
I suspected it because you have modified that platform specific function related to IPC, both change of signature and usage. Build failures can be because of conflicting prototype and definition of this function on the non-CAVS platforms? |
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Blocking until the implementation is adjusted on all platforms. As of this review, non-CAVS platforms fail the build.
tlauda
force-pushed
the
topic/detect-notify-improvements
branch
from
9811df6 to
be28b88
Compare
paulstelian97
dismissed
their stale review
Dismiss as issue is resolved, I will re-review now.
| ipc_platform_send_msg(&cd->msg); | ||
| if (ipc_platform_send_msg(&cd->msg) < 0) | ||
| /* Other notification in progress, so just add to the list */ | ||
| list_item_prepend(&cd->msg.list, &ipc_get()->msg_list); |
There was a problem hiding this comment.
The prepending should be in the IPC core. i.e. we should have a new IPC API
int ipc_platform_send_msg_queue(msg, priority, remove_duplicates);
Where priority HIGH would mean we insert new message at list head, otherwise it's list tail. The remove duplicates bool means to remove any older messages from this sender and use this message. Handy if we are sending any high frequency updates and want to remove stale or older updates.
This should be called directly instead of existing method (and will acquire any locks etc)..
|
@tlauda any reason to close ? Is there another fix ? |
4 participants
Adds notification to the beginning of the list if there is some
other IPC notification being sent.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com