ext_manifest: byt: fix .fw_metadata section alignment #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section of this section should be aligned to EXT_MAN_ALIGN, proper way of doing this with ALIGN() function inside linker script didn't work, because of removing READONLY attribute for this segment, what leads to error in rimage. This solution introduce changes only for platforms, where problem exists, so generic tools like rimage are kept clean of such a hacks. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Member
Author
|
proper CI test run in #2957 |
lgirdwood
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section of this section should be aligned to EXT_MAN_ALIGN,
proper way of doing this with ALIGN() function inside linker
script didn't work, because of removing READONLY attribute
for this segment, what leads to error in rimage.
This solution introduce changes only for platforms, where problem
exists, so generic tools like rimage are kept clean of such a hacks.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com