Skip to content

ext_manifest: byt: fix .fw_metadata section alignment #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
May 27, 2020
Merged

ext_manifest: byt: fix .fw_metadata section alignment #2960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/platform/baytrail/baytrail.x.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,8 @@ SECTIONS

.fw_metadata (COPY) : ALIGN(1024)
{
KEEP (*(.fw_metadata))
KEEP (*(.fw_metadata));
KEEP (*(.fw_metadata.align));
} >fw_metadata_seg :metadata_entries_phdr

.fw_ready : ALIGN(4)
Expand Down
11 changes: 11 additions & 0 deletions src/platform/baytrail/platform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,24 @@
#include <ipc/header.h>
#include <ipc/info.h>
#include <kernel/abi.h>
#include <kernel/ext_manifest.h>
#include <config.h>
#include <version.h>
#include <errno.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>

/*
* following element is created to assure proper section size alignment, besides
* of build tools limitation - removing `READONLY` flag when updated `.` value
* with `ALIGN(.)` in linker script.
*/
const struct {
char elem[0];
} ext_manifest_align_element
__aligned(EXT_MAN_ALIGN) __section(".fw_metadata.align") = {};

static const struct sof_ipc_fw_ready ready
__section(".fw_ready") = {
.hdr = {
Expand Down