Skip to content

Conversation

@fredoh9
Copy link
Contributor

@fredoh9 fredoh9 commented Aug 18, 2020

GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
8 digits.

Signed-off-by: Fred Oh fred.oh@linux.intel.com

fixes: #3322

@ktrzcinx ktrzcinx added the P1 Blocker bugs or important features label Aug 19, 2020
@plbossart
Copy link
Member

Maybe complete nonsense, but does this take the first 8 digits or the 8 last? the latter might be difficult to use?

@ktrzcinx
Copy link
Member

@plbossart the first 8 digits

@mmaka1
Copy link

mmaka1 commented Aug 19, 2020

Should the commit message include a hash of the original commit being fixed?

@fredoh9
Copy link
Contributor Author

fredoh9 commented Aug 19, 2020

Should the commit message include a hash of the original commit being fixed?

Should I make this as a fixup commit then?

@fredoh9 fredoh9 force-pushed the fix/sof_hash_error branch from 53aaa15 to d19577f Compare August 19, 2020 18:06
@fredoh9
Copy link
Contributor Author

fredoh9 commented Aug 19, 2020

fixup commit is making sense. Changed to fixup of 60b737a.
fixup! sof: Calculate source code hash

@fredoh9 fredoh9 force-pushed the fix/sof_hash_error branch from d19577f to 11e8c9e Compare August 19, 2020 18:27
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.

@fredoh9 fredoh9 force-pushed the fix/sof_hash_error branch from 11e8c9e to e4ec45a Compare August 20, 2020 19:10
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
first 8 digits.

Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
@fredoh9
Copy link
Contributor Author

fredoh9 commented Aug 20, 2020

Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.

Commit subject is fixup, sorry for missing commit message. I didn't pay attention to the message when using --fixup.

@fredoh9 fredoh9 requested a review from lgirdwood August 20, 2020 19:13
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredoh9 you may have pushed the wrong branch, it's still showing the wrong subject. Best to rebase and check with git log prior to force pushing.

@lgirdwood
Copy link
Member

@fredoh9 I've fixed the subject and pushed here. #3331. closing this one.

@lgirdwood lgirdwood closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] APL/CNL Build failed due to bigger SOF_SRC_HASH

5 participants