-
Notifications
You must be signed in to change notification settings - Fork 349
cmake: set git hash to 8 digit #3323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe complete nonsense, but does this take the first 8 digits or the 8 last? the latter might be difficult to use? |
|
@plbossart the first 8 digits |
|
Should the commit message include a hash of the original commit being fixed? |
Should I make this as a fixup commit then? |
53aaa15 to
d19577f
Compare
|
fixup commit is making sense. Changed to fixup of 60b737a. |
d19577f to
11e8c9e
Compare
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the commit subject and add a commit message. It looks like these are in the GH PR but not the patch.
11e8c9e to
e4ec45a
Compare
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to first 8 digits. Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
Commit subject is fixup, sorry for missing commit message. I didn't pay attention to the message when using --fixup. |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fredoh9 you may have pushed the wrong branch, it's still showing the wrong subject. Best to rebase and check with git log prior to force pushing.
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
8 digits.
Signed-off-by: Fred Oh fred.oh@linux.intel.com
fixes: #3322