cmake: set git hash to 8 digit #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
force-pushed
the
lrg/topic/cmake
branch
from
9d942d5 to
33c48f4
Compare
Member
Author
|
@fredoh9 can you check this - I've had to fix both SUBSTRING ranges as they overflow. |
Member
Author
|
All targets build locally with GCC. |
ktrzcinx
reviewed
Aug 21, 2020
scripts/cmake/version.cmake
Outdated
Comment on lines
83
to
84
Member
There was a problem hiding this comment.
string(SUBSTRING <string> <begin> <length> <out-var>)
string(SUBSTRING 1234567890 0 7 SOF_SRC_HASH) gives result Source content hash: 1234567 1234-567, so value 8 shouldn't overflow uint32_t src_hash;
Contributor
There was a problem hiding this comment.
yes, i tested with my local build also. 2nd number is length, so 8
Member
Author
There was a problem hiding this comment.
ok thanks guys - and now this works for me. I must have put in 9 as a typo when testing as it failed on overflow !
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to first 8 digits. fixes: #3322 Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
lgirdwood
force-pushed
the
lrg/topic/cmake
branch
from
33c48f4 to
5712792
Compare
ktrzcinx
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIT_LOG_HASH can be more than 8 digits. Limit hash value up to
first 8 digits.
fixes: #3322
Signed-off-by: Fred Oh fred.oh@linux.intel.com