cmake: allow testbench to build with clang #3458
Conversation
|
related to #3388 |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I spent some time researching this (sorry for the delay) and I think we can do much simpler: simply remove -ftree-vectorizer-verbose=0 entirely. Why? Two reasons:
-
This option was removed in gcc 4.9 released in 2014:
https://gcc.gnu.org/onlinedocs/gcc-4.8.5/gcc/Debugging-Options.html
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Debugging-Options.html
It's been replaced by -fopt-info now.
(for the record it was added in 2005: https://gcc.gnu.org/legacy-ml/gcc-patches/2005-01/msg01247.html) -
More importantly, I'm 99% sure
=0was the default value anyway for the simple reason it's a "Debugging Option". So this option was a no-op for all this time!
@ranj063 do you remember why you added -ftree-vectorizer-verbose=0 in commit 0505823 ? It wasn't in this git repo before that commit.
@lgirdwood any idea? |
To build the processing components and vectorise for SSE SIMD on x86, can be safely removed now as GCC does this differently now as detailed above. |
This particular option did not change anything to what was built, it only made sure verbosity was zero (which was very likely the default already)
Great. |
|
I have no clue what happened. I pushed the branch from a different machine and the PR is closed. My only guess is it forced it closed because this commit wasn't signed by gpg. I will amend the commit later today and repush to fix this (hopefully) |
|
nevermind, I think i pushed the wrong thing |
We need clang support for the testbench therefore the following changes are needed remove -ftree-vectorizer-verbose since its deprecated in gcc and not supported in clang remove =3 from -Wimplicit-fallthrough=3 since 3 is the default level anyways Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
|
CI showing DUT HW not tested failure unrelated to PR. |
3 participants
We need clang support for the testbench therefore the following changes
are needed
remove -ftree-vectorizer-verbose when building with clang
remove =3 from -Wimplicit-fallthrough=3 since 3 is the default level
anyways
Signed-off-by: Curtis Malainey cujomalainey@chromium.org